-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rds_cluster_snapshot - new module to handle RDS cluster snapshotting #788
rds_cluster_snapshot - new module to handle RDS cluster snapshotting #788
Conversation
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
recheck |
Build failed.
|
Build failed.
|
recheck |
recheck |
recheck |
Build failed.
|
Build failed.
|
Ah, completely forgot. will need to merge #687 first. Not sure if we can include these two in this release at this point. |
4f7a535
to
99b8b9b
Compare
recheck |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Oops I approved twice :) |
Add support for copy_db_cluster_snapshot for rds_cluster_snapshot SUMMARY Add support for copy_db_cluster_snapshot for rds_cluster_snapshot Necessary for ansible-collections/community.aws#788 Just to verify: Depends-On: ansible/ansible-zuul-jobs#1520 ISSUE TYPE Feature Pull Request COMPONENT NAME module_utils/rds.py ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like although you've added the retry decorator, nothing's actually using aws_retry=True, so the decorator won't be used...
Thought for 5.0.0, should we change the default for aws_retry to True?
Signed-off-by: Alina Buzachis <[email protected]>
I guess that would be awesome! |
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1238 🤖 @patchback |
…788) rds_cluster_snapshot - new module to handle RDS cluster snapshotting SUMMARY rds_cluster_snapshot - new module to handle RDS cluster snapshotting Requires rds_cluster to be merged first #687 Depends-On: ansible-collections/amazon.aws#840 Requires: mattclay/aws-terminator#212 Requires also mattclay/aws-terminator#184 ISSUE TYPE New Module Pull Request COMPONENT NAME rds_cluster_snapshot Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 5e7acbd)
…sible-collections#840) Add support for copy_db_cluster_snapshot for rds_cluster_snapshot SUMMARY Add support for copy_db_cluster_snapshot for rds_cluster_snapshot Necessary for ansible-collections/community.aws#788 Just to verify: Depends-On: ansible/ansible-zuul-jobs#1520 ISSUE TYPE Feature Pull Request COMPONENT NAME module_utils/rds.py ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None>
…nsible-collections#788) rds_cluster_snapshot - new module to handle RDS cluster snapshotting SUMMARY rds_cluster_snapshot - new module to handle RDS cluster snapshotting Requires rds_cluster to be merged first ansible-collections#687 Depends-On: ansible-collections/amazon.aws#840 Requires: mattclay/aws-terminator#212 Requires also mattclay/aws-terminator#184 ISSUE TYPE New Module Pull Request COMPONENT NAME rds_cluster_snapshot Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@5e7acbd
SUMMARY
rds_cluster_snapshot
- new module to handle RDS cluster snapshottingRequires
rds_cluster
to be merged first #687Depends-On: ansible-collections/amazon.aws#840
Requires: mattclay/aws-terminator#212
Requires also mattclay/aws-terminator#184
ISSUE TYPE
COMPONENT NAME
rds_cluster_snapshot