-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add py3.9 test jobs #1520
Add py3.9 test jobs #1520
Conversation
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
--- | ||
- hosts: all | ||
tasks: | ||
- name: Ensure python3.9 is present (Debian/Ubuntu) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have any Ubuntu left. You can just keep the second task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Removed.
zuul.d/jobs.yaml
Outdated
- job: | ||
name: ansible-test-units-base-python39 | ||
parent: ansible-test-units-base | ||
nodeset: controller-python39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use the fedora-35-1vcpu
nodeset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
zuul.ansible.d/nodesets.yaml
Outdated
@@ -625,6 +625,16 @@ | |||
nodes: | |||
- fedora-35 | |||
|
|||
- nodeset: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer we don't had yet another controller-pythonXY
node. This is a bit pointless since they all point on Fedora 35 BTW :-).
zuul.sf.d/ansible-cloud-jobs.yaml
Outdated
@@ -280,7 +280,7 @@ | |||
- job: | |||
name: ansible-test-cloud-integration-aws | |||
parent: ansible-core-ci-aws-session | |||
nodeset: controller-python38 | |||
nodeset: controller-python39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same, you can just use fedora-35-1vcpu
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
zuul.sf.d/nodesets.yaml
Outdated
@@ -337,6 +337,12 @@ | |||
- name: controller | |||
label: ansible-fedora-35-1vcpu | |||
|
|||
- nodeset: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same, you can remove this entry. BTW the file doesn't exist anymore \o/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed!
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Signed-off-by: Alina Buzachis <[email protected]>
e1f7e21
to
b346dbb
Compare
Zuul encountered a syntax error while parsing its configuration in the Job ansible-test-cloud-integration-vmware-rest-python38 not defined The error appears in the following project-template stanza: project-template: in "ansible/ansible-zuul-jobs/zuul.d/project-templates.yaml@master", line 586, column 3 |
Signed-off-by: Alina Buzachis <[email protected]>
@goneri This job was missing. Not sure if you want to keep it as ansible-test-cloud-integration-vmware-rest or ansible-test-cloud-integration-vmware-rest-python39? It seems ansible-test-cloud-integration-vmware-rest uses already python 3.9 (if I am not mistaken). |
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 4m 58s |
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 5m 33s |
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 4m 39s |
Add support for copy_db_cluster_snapshot for rds_cluster_snapshot SUMMARY Add support for copy_db_cluster_snapshot for rds_cluster_snapshot Necessary for ansible-collections/community.aws#788 Just to verify: Depends-On: ansible/ansible-zuul-jobs#1520 ISSUE TYPE Feature Pull Request COMPONENT NAME module_utils/rds.py ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None>
…sible-collections#840) Add support for copy_db_cluster_snapshot for rds_cluster_snapshot SUMMARY Add support for copy_db_cluster_snapshot for rds_cluster_snapshot Necessary for ansible-collections/community.aws#788 Just to verify: Depends-On: ansible/ansible-zuul-jobs#1520 ISSUE TYPE Feature Pull Request COMPONENT NAME module_utils/rds.py ADDITIONAL INFORMATION Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None>
No description provided.