Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action/ce.py:clear configuration candidate when return to user-view. #63513

Merged
merged 4 commits into from
Oct 18, 2019
Merged

action/ce.py:clear configuration candidate when return to user-view. #63513

merged 4 commits into from
Oct 18, 2019

Conversation

yuandongx
Copy link
Contributor

@yuandongx yuandongx commented Oct 15, 2019 •
edited
Loading

SUMMARY

Clear configuration candidate when return to user-view.
For some new software-versions, return will not discard uncommited configure directly,but it will give a prompt to wait confirm.In this case, ansible connection will trigger a time out error until time is out.
So fix it.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/action/ce.py

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Oct 15, 2019
@yuandongx yuandongx marked this pull request as ready for review October 15, 2019 15:15
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 18, 2019
@zhongjun2
Copy link
Contributor

LGTM

@gundalow gundalow merged commit 47c31c2 into ansible:devel Oct 18, 2019
@yuandongx
Copy link
Contributor Author

@gundalow @zhongjun2 thank you so much.

@yuandongx yuandongx deleted the bug_ce_action branch October 18, 2019 09:14
This was referenced Oct 19, 2019
Merged
Closed
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Oct 22, 2019
@yuandongx yuandongx mentioned this pull request Oct 22, 2019
Merged
abadger pushed a commit that referenced this pull request Oct 31, 2019
@yuandongx @abadger
action/ce.py:clear configuration candidate when return to user-view. (#…
bd26e70 
…63513)

* clear configuration candidate when return to user-view.

* add a changelog fragment for the pr.

* Update 63513-ce_action_wait_prompt_trigger_time_out.yaml

* Update 63513-ce_action_wait_prompt_trigger_time_out.yaml

(cherry picked from commit 47c31c2)
abadger pushed a commit that referenced this pull request Nov 1, 2019
@yuandongx @abadger
action/ce.py:clear configuration candidate when return to user-view. (#…
30bbbdb 
…63513)

* clear configuration candidate when return to user-view.

* add a changelog fragment for the pr.

* Update 63513-ce_action_wait_prompt_trigger_time_out.yaml

* Update 63513-ce_action_wait_prompt_trigger_time_out.yaml

(cherry picked from commit 47c31c2)
nitzmahone pushed a commit that referenced this pull request Nov 12, 2019
@yuandongx @nitzmahone
action/ce.py:clear configuration candidate when return to user-view. (#…
d3a9bbc 
…63513) (#63704)

* clear configuration candidate when return to user-view.

* add a changelog fragment for the pr.

* Update 63513-ce_action_wait_prompt_trigger_time_out.yaml

* Update 63513-ce_action_wait_prompt_trigger_time_out.yaml

(cherry picked from commit 47c31c2)
@ansible ansible locked and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zhongjun2 zhongjun2 zhongjun2 left review comments

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yuandongx @zhongjun2 @sivel @gundalow @ansibot