Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/2.9/63513 action/ce.py:clear configuration candidate when return to user-view. … #63796

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Backport/2.9/63513 action/ce.py:clear configuration candidate when return to user-view. … #63796

merged 1 commit into from
Oct 31, 2019

Conversation

yuandongx
Copy link
Contributor

…(#63513)

  • clear configuration candidate when return to user-view.

  • add a changelog fragment for the pr.

  • Update 63513-ce_action_wait_prompt_trigger_time_out.yaml

  • Update 63513-ce_action_wait_prompt_trigger_time_out.yaml

(cherry picked from commit 47c31c2)

SUMMARY

Clear configuration candidate when return to user-view.
For some new software-versions, return will not discard uncommited configure directly,but it will give a prompt to wait confirm.In this case, ansible connection will trigger a time out error until time is out.
So fix it.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/action/ce.py

ADDITIONAL INFORMATION

@yuandongx
action/ce.py:clear configuration candidate when return to user-view. (#…
7ef7e42 
…63513)

* clear configuration candidate when return to user-view.

* add a changelog fragment for the pr.

* Update 63513-ce_action_wait_prompt_trigger_time_out.yaml

* Update 63513-ce_action_wait_prompt_trigger_time_out.yaml

(cherry picked from commit 47c31c2)
@ansibot ansibot added backport This PR does not target the devel branch. bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Oct 22, 2019
@ansibot
Copy link
Contributor

ansibot commented Oct 30, 2019

cc @QijunPan @TommyLike @edisonxiang @freesky-edward @hwDCN @niuzhenguo @zengchen1024 @zhongjun2
click here for bot help

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. huawei Huawei community networking Network category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:network This issue/PR relates to code supported by the Ansible Network Team. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Oct 30, 2019
@yuandongx yuandongx closed this Oct 31, 2019
@yuandongx yuandongx reopened this Oct 31, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 31, 2019
@abadger abadger merged commit bd26e70 into ansible:temporary-2.9.1-branch-releng-only Oct 31, 2019
@abadger
Copy link
Contributor

abadger commented Oct 31, 2019

Merged for the 2.9.1 release

@yuandongx yuandongx deleted the Backport/2.9/63513 branch November 1, 2019 01:28
@yuandongx yuandongx mentioned this pull request Nov 1, 2019
Closed
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Nov 13, 2019
@ansible ansible locked and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. huawei Huawei community networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yuandongx @ansibot @abadger @sivel