Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Python 3.11 as an experimental stage #80

Merged
merged 8 commits into from
Oct 28, 2022
Merged

Conversation

RobPasMue
Copy link
Member

Provide support for Python 3.11 (experimental)

@RobPasMue RobPasMue self-assigned this Oct 25, 2022
@RobPasMue RobPasMue requested a review from jorgepiloto October 26, 2022 12:54
@RobPasMue
Copy link
Member Author

@jorgepiloto, PR ready for review

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about following the "weekly cron" approach we did in ansys/pyansys-geometry#200?

My only concern is about having this in our main ci-build.yml workflow. For sure most libraries out there will provide full support for Python 3.11 soon, but not sure about VTK in the short-term.

Anyway, if we faced some issues, we can always take advantage of VCS to go back in time. Approving 🚀

@RobPasMue
Copy link
Member Author

Oh shoot. I forgot to update this PR!!

Also going with the "weekly cron" approach for now. Let me redo this PR

@RobPasMue RobPasMue enabled auto-merge (squash) October 28, 2022 09:25
@RobPasMue RobPasMue merged commit d12e4a0 into main Oct 28, 2022
@RobPasMue RobPasMue deleted the feat/python-311 branch October 28, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants