Feat/local params #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
seanpearsonuk
commented
Jul 20, 2022
•
seanpearsonuk
commented
- classes to set up a parametric study locally, i.e. in PyFluent without running Fluent. Knowledge of parameters comes directly from a case file
- functionality to execute the locally defined parametric study in parallel. This uses the existing parametric classes
- a Fluent case reader to facilitate the local parametric study. Here temporarily - see PR in core repository. Eventually to a separate repo?
- lispy.py. This provides a Scheme parser, copied from the web. It was necessary to make a few adjustments. Null / empty list triggered an exception, while (1 . 2) was interpreted as [1, '.', 2], for which I generate [1, 2]. This will also move.
- changes in the core parametric classes. Removed static data from the study class to allow multiple non-interfering sessions.
|
@tejalprabhu01 I have added you here to check that these change don't break optiSLang->PyFluent. |
seanpearsonuk
commented
Jul 21, 2022
ajain-work
reviewed
Jul 22, 2022
ajain-work
reviewed
Jul 22, 2022
mkundu1
approved these changes
Jul 22, 2022
@seanpearsonuk I have reviewed the changes. Nothing breaks on optiSLang side. Thanks. |
tejalprabhu01
approved these changes
Jul 22, 2022
seanpearsonuk
force-pushed
the
feat/local_params
branch
from
83118dd to
3c66f9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.