-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/caseread #654
Merged
Merged
Feat/caseread #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
seanpearsonuk
commented
Jul 21, 2022
- a Fluent case reader to facilitate the local parametric study here , and to allow launch fluent based on case file args (to follow)
- lispy.py. This provides a Scheme parser, copied from the web. It was necessary to make a few adjustments. Null / empty list triggered an exception, while (1 . 2) was interpreted as [1, '.', 2], for which I generate [1, 2].
mkundu1
reviewed
Jul 22, 2022
seanpearsonuk
force-pushed
the
feat/caseread
branch
from
July 22, 2022 18:54
4ca9e9a
to
8e518a4
Compare
seanpearsonuk
commented
Jul 23, 2022
mkundu1
approved these changes
Jul 23, 2022
hpohekar
approved these changes
Jul 25, 2022
tejalprabhu01
approved these changes
Jul 25, 2022
prmukherj
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.h5 reader is running fine. Case file can also be loaded to fluent with an extra argument added in the launcher.
seanpearsonuk
force-pushed
the
feat/caseread
branch
from
July 25, 2022 09:32
8e518a4
to
92e79d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.