also allow ingestion of Push with LegacyVersion to prevent amplificat…

…ions
anza-xyz · Feb 4, 2025 · da0b1e5 · da0b1e5
1 parent 814abfa
commit da0b1e5
Showing 1 changed file with 4 additions and 12 deletions.
diff --git a/gossip/src/protocol.rs b/gossip/src/protocol.rs
@@ -165,18 +165,10 @@ impl Sanitize for Protocol {
                 val.sanitize()
             }
             Protocol::PushMessage(_, val) => {
-                //Push is allowed to carry anything in its CrdsData, except for deprecated fields
-                for v in val {
-                    match v.data() {
-                        CrdsData::LegacyVersion(_) => {
-                            return Err(SanitizeError::InvalidValue);
-                        }
-                        _ => {
-                            v.sanitize()?;
-                        }
-                    }
-                }
-                Ok(())
+                // PushMessage is allowed to carry anything in its CrdsData, including deprecated Crds
+                // such that a deprecated Crds gets ingested instead of the node having to pull it from
+                // other nodes that have inserted it into their Crds table
+                val.sanitize()
             }
             Protocol::PruneMessage(from, val) => {
                 if *from != val.pubkey {