Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update deploy-with-docker.md #2472

Merged
merged 5 commits into from
Jul 4, 2022
Merged

Conversation

FangSen9000
Copy link
Contributor

@FangSen9000 FangSen9000 commented Jun 13, 2022

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

apisix-dashboard login success,then access apisix/admin/labels/route or apisix/admin/labels/consumer ,encounter to get 401 Unauthorized error code,which means the jwt token that authoried by dashboard is invalid.

finally with community's help,found that the reason is more than 1 dashboard instance.
with multi instance, every instance generate and hold a jwt token,will cause validation conflicted

so we can optimize the doc to emphasize the dashboard instance number not more than 1,DIFFERENT from high availability with apisix itself.

optimize the doc,emphasize the dashboard instance number not more than 1

I have added comments in the appropriate place in the Docker-related documentation.

Related issues

fix/resolve [doc] 仪表板 Docker 实现使用优化 issues#2446

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@FangSen9000
Copy link
Contributor Author

@Baoyuantop, I accidentally changed the file name before, but only changed the content this time.

Copy link
Member

@SkyeYoung SkyeYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls refer to other PRs to edit your title.

docs/en/latest/deploy-with-docker.md Outdated Show resolved Hide resolved
@SkyeYoung
Copy link
Member

Pls also revise the description of the PR in English to make it accurate and clear.

@FangSen9000 FangSen9000 changed the title Update deploy-with-docker.md docs: update deploy-with-docker.md Jun 14, 2022
@juzhiyuan juzhiyuan merged commit 36f1ba9 into apache:master Jul 4, 2022
bzp2010 pushed a commit to bzp2010/apisix-dashboard that referenced this pull request Jul 13, 2022
hongbinhsu pushed a commit to fitphp/apix-dashboard that referenced this pull request Sep 10, 2022
* upstream/master: (23 commits)
  feat: Add config struct of OpenID-Connect Login (apache#2597)
  feat: set serverUrlMap with env, update cypress, update stylelint (apache#2583)
  chore: fix function name typo (apache#2599)
  fix: page refresh causes deletion exception (apache#2593)
  feat: support show all enable plugin list tab (apache#2585)
  fix: drawer components delete plugin not working (apache#2573)
  feat: add batch delete function for route (apache#2502)
  test: reduce fe ci time (apache#2557)
  doc(csp): add correct csp rule (apache#2548)
  doc: add a notice about the compatibility of Ingress and Dashboard (apache#2552)
  fix: add judgement for last_report_time (apache#2551)
  fix: cli test invalid etcd (apache#2544)
  feat: fix actions version to root version (apache#2521)
  fix: duplicate ID (apache#2501)
  fix: block arbitrary file index (apache#2497)
  docs: update deploy-with-docker.md (apache#2472)
  feat: translating Turkish for new features (apache#2487)
  docs: add new import and export docs to sidebar (apache#2485)
  docs: add data loader and new OpenAPI 3 loader (apache#2484)
  feat: support data loader in frontend (apache#2480)
  ...

# Conflicts:
#	api/internal/route.go
#	web/config/defaultSettings.ts
#	web/yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants