feat: Adding batch deletion function for routing pages #2502
Conversation
Co-authored-by: Young <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2502 +/- ##
==========================================
- Coverage 75.92% 67.00% -8.92%
==========================================
Files 136 133 -3
Lines 3576 3537 -39
Branches 864 850 -14
==========================================
- Hits 2715 2370 -345
- Misses 861 1167 +306
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Pls try to follow the lint CI to fix lint problems |
|
@FangSen9000 Any update here? |
|
|
@Baoyuantop @guoqqqi Do you have any questions or comments on this test case? If not, you can approve it, and then let the back-end testers debug their use cases |
|
|
|
ok
…------------------ 原始邮件 ------------------
发件人: "Qi ***@***.***>;
发送时间: 2022年8月7日(星期天) 晚上10:29
收件人: ***@***.***>;
抄送: ***@***.***>; ***@***.***>;
主题: Re: [apache/apisix-dashboard] feat: Adding batch deletion function for routing pages (PR #2502)
一个很好的提示是，通常这些评论的内容不应该被标记为由你解决，而是由为你审核的人😄
—
直接回复此邮件，在GitHub上查看，或取消订阅.
***@***.***与>
|
Co-authored-by: Qi Guo <[email protected]>
I made some mistakes after I adopted the code. Do you have any good suggestions. Is there any way to solve it? I'm debugging your update on the local machine |
you need update the i18n file for |
|
@guoqqqi I got it on the local machine, should pass him in as a variable. There was a slight problem with the syntax, which has now been resolved. You're missing a '$'. Thanks for your suggestion. |
|
|
@guoqqqi I have completed the changes you suggested. Check that everything is normal |
| cy.contains(data.test0).should('not.exist'); | ||
| cy.contains(data.test1).should('not.exist'); | ||
| cy.contains(data.test2).should('not.exist'); | ||
| }); |
There was a problem hiding this comment.
Why do we need to test these search functions? We only need to judge that the data does not exist under https://github.com/apache/apisix-dashboard/pull/2502/files#diff-6918beb43c48e71616c503a8dffc6d9cc572f37a69d1e27f792b71fda2e5416aR117.
|
These two assertions remove the name and content of the route, respectively. I think it has three advantages :
1. It can prevent only deleting the key in the route attribute, but not completely delete the route
2. It IS possible that THE TEST case on PAGE 2 will not BE FOUND IF there ARE more test cases later on.
3. The search function automatically refreshes the page, which can prevent timeout errors due to unrendered, and can make the test case more stable
…---Original---
From: ***@***.***>
Date: Mon, Aug 8, 2022 09:54 AM
To: ***@***.***>;
Cc: ***@***.******@***.***>;
Subject: Re: [apache/apisix-dashboard] feat: Adding batch deletion functionfor routing pages (PR #2502)
@Baoyuantop commented on this pull request.
In web/cypress/integration/route/batch-delete-route.spec.js:
> + cy.contains(data.test1).should('not.exist'); + cy.contains(data.test0).should('not.exist'); + cy.contains(data.test2).should('not.exist'); + // partial match + cy.get(selector.nameSearchInput).clear().type(data.test2); + cy.contains('Search').click(); + cy.contains(data.test0).should('not.exist'); + cy.contains(data.test1).should('not.exist'); + cy.contains(data.test2).should('not.exist'); + // no match + cy.get(selector.nameSearchInput).clear().type(data.testx); + cy.contains('Search').click(); + cy.contains(data.test0).should('not.exist'); + cy.contains(data.test1).should('not.exist'); + cy.contains(data.test2).should('not.exist'); + });
Why do we need to test these search functions? We only need to judge that the data does not exist under https://github.com/apache/apisix-dashboard/pull/2502/files#diff-6918beb43c48e71616c503a8dffc6d9cc572f37a69d1e27f792b71fda2e5416aR117.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
* upstream/master: (23 commits) feat: Add config struct of OpenID-Connect Login (apache#2597) feat: set serverUrlMap with env, update cypress, update stylelint (apache#2583) chore: fix function name typo (apache#2599) fix: page refresh causes deletion exception (apache#2593) feat: support show all enable plugin list tab (apache#2585) fix: drawer components delete plugin not working (apache#2573) feat: add batch delete function for route (apache#2502) test: reduce fe ci time (apache#2557) doc(csp): add correct csp rule (apache#2548) doc: add a notice about the compatibility of Ingress and Dashboard (apache#2552) fix: add judgement for last_report_time (apache#2551) fix: cli test invalid etcd (apache#2544) feat: fix actions version to root version (apache#2521) fix: duplicate ID (apache#2501) fix: block arbitrary file index (apache#2497) docs: update deploy-with-docker.md (apache#2472) feat: translating Turkish for new features (apache#2487) docs: add new import and export docs to sidebar (apache#2485) docs: add data loader and new OpenAPI 3 loader (apache#2484) feat: support data loader in frontend (apache#2480) ... # Conflicts: # api/internal/route.go # web/config/defaultSettings.ts # web/yarn.lock
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
Please update this section with detailed description.
批量删除.webm
You can watch this video for a preview.
On the routing page, the user cannot delete in the state of select all or batch delete. I added related operations.
When selecting multiple or single items, a footer bar will pop up for batch deletion of table data. The deselect button will appear in the title of the table.
It also has full and anti - full pages
Related issues
#2565
#2562
Checklist: