-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: optimize "allow_origins_by_regex tooltip" description #2690
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -49,7 +49,7 @@ export default { | |||
'component.pluginForm.cors.allow_origins_by_metadata.tooltip': | |||
'Eklenti meta verilerindeki allow_origins kümesine başvurarak CORSu etkinleştirmek için hangi Origine izin verildiğini eşleştirin.', | |||
'component.pluginForm.cors.allow_origins_by_regex.tooltip': | |||
'CORSu etkinleştirmek için hangi Origine izin verildiğini eşleştirmek için normal ifade ifadeleri kullanın, örneğin, [".*.test.com"], test.comun tüm alt alan adlarını eşleştirmek için kullanabilir.', | |||
'CORSu etkinleştirmek için izin verilen kaynakları eşleştirmek için regex ifadelerini kullanın. Her form sadece tek bir, bağımsız düzenli ifadeyle yapılandırılabilir, örneğin ".*.test.com" gibi, test.com\'un her alt etki alanını eşleştirebilir.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Co-authored-by: Zeping Bai <[email protected]>
Co-authored-by: Zeping Bai <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #2690 +/- ##
==========================================
+ Coverage 63.85% 67.98% +4.12%
==========================================
Files 186 39 -147
Lines 7172 1040 -6132
Branches 874 268 -606
==========================================
- Hits 4580 707 -3873
+ Misses 2389 333 -2056
+ Partials 203 0 -203
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
* upstream/master: feat: release 3.0.0 (apache#2722) Revert "feat: release 2.16.0 (apache#2719)" (apache#2721) feat: release 2.16.0 (apache#2719) fix: plugin configuration lost in editor (apache#2718) fix: adapt APISIX plugin disabled (apache#2717) feat: basic support Apache APISIX 3.0.0 (apache#2701) feat: change etcd prefix for ssl and proto (apache#2693) fix: remove cases external service dependency (apache#2697) chore: simplify e2e environment (apache#2694) chore: optimize "allow_origins_by_regex tooltip" description (apache#2690) feat: release 2.15.0 (apache#2685) feat: basic support Apache APISIX 2.15.0 (apache#2680) feat: release 2.14.0 (apache#2677) fix: bump go version to 1.16 (apache#2678) feat: release 2.13.1 (apache#2658) feat: support more upstream scheme (apache#2675) feat: support purge method (apache#2674) feat: add enable flag to oidc function (apache#2672) # Conflicts: # web/package.json
On the Cors plugin config page, the allow_origins_by_regex help message is misleading the user.
This PR optimize "allow_origins_by_regex tooltip" description。
Related issues
fix/resolve #2669