Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: release 2.16.0 #2719

Merged
merged 3 commits into from
Jan 27, 2023
Merged

feat: release 2.16.0 #2719

merged 3 commits into from
Jan 27, 2023

Conversation

Baoyuantop
Copy link
Contributor

@Baoyuantop Baoyuantop commented Jan 20, 2023 •
edited
Loading

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Released version 2.16.0. It is basically compatible with APISIX 3.0.0.

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2023 •
edited
Loading

Codecov Report

Merging #2719 (1738403) into master (688afa2) will decrease coverage by 10.82%.
The diff coverage is n/a.

❗ Current head 1738403 differs from pull request most recent head e826651. Consider uploading reports for the commit e826651 to get more accurate results

@@             Coverage Diff             @@
##           master    #2719       +/-   ##
===========================================
- Coverage   76.39%   65.57%   -10.82%     
===========================================
  Files         139      101       -38     
  Lines        3754     5119     +1365     
  Branches      874      268      -606     
===========================================
+ Hits         2868     3357      +489     
- Misses        886     1396      +510     
- Partials        0      366      +366
Flag Coverage Δ
backend-e2e-test-ginkgo 64.96% <ø> (?)
frontend-e2e-test 67.98% <ø> (-8.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/helpers.tsx 19.67% <0.00%> (-57.38%) ⬇️
web/src/components/RightContent/AvatarDropdown.tsx 50.00% <0.00%> (-32.15%) ⬇️
web/src/components/PanelSection/index.tsx 75.00% <0.00%> (-25.00%) ⬇️
...b/src/components/Plugin/UI/referer-restriction.tsx 69.69% <0.00%> (-21.22%) ⬇️
web/src/pages/Consumer/List.tsx 73.17% <0.00%> (-19.52%) ⬇️
web/src/components/Plugin/PluginPage.tsx 82.00% <0.00%> (-17.00%) ⬇️
web/src/components/ActionBar/ActionBar.tsx 69.23% <0.00%> (-15.39%) ⬇️
web/src/app.tsx 87.87% <0.00%> (-12.13%) ⬇️
web/src/components/Plugin/UI/cors.tsx 71.11% <0.00%> (-11.12%) ⬇️
web/src/components/Plugin/PluginDetail.tsx 64.48% <0.00%> (-10.93%) ⬇️
... and 168 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@juzhiyuan
Copy link
Member

Please check the CI

@juzhiyuan
Copy link
Member

Just to confirm: this PR doesn't need code changes?

@SkyeYoung
Copy link
Member

Hi guys, I think we should add all PRs and issues related to this release to the PR description. 🤔

(This may make it easier for people to understand what this PR has done.)

@bzp2010
Copy link
Contributor

bzp2010 commented Jan 23, 2023

Actually I don't think this should be called 3.0.0, it's still a 2.x branch compatible version of APISIX 3.0, not the real 3.0. we'd better call it 2.16 or 2.99.

@Baoyuantop
Copy link
Contributor Author

I agree with 2.16, what do you think?

@Baoyuantop
Copy link
Contributor Author

Hi guys, I think we should add all PRs and issues related to this release to the PR description. 🤔

(This may make it easier for people to understand what this PR has done.)

As per the previous release PR, we did not do this and this information will be included in the changelog

@Baoyuantop Baoyuantop changed the title feat: release 3.0.0 feat: release 2.16.0 Jan 25, 2023
juzhiyuan
juzhiyuan reviewed Jan 26, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
bzp2010
bzp2010 approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@bzp2010 bzp2010 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, given that the version numbers are currently no longer aligned with APISIX, I think we need to provide a compatibility list and we can do this in the next PR. Just like:

APISIX ver APISIX Dashboard ver
3.0 2.16.x
2.15 2.15.x
2.14 2.14.x
..... .....

@Baoyuantop
Copy link
Contributor Author

LGTM, given that the version numbers are currently no longer aligned with APISIX, I think we need to provide a compatibility list and we can do this in the next PR. Just like:

APISIX ver APISIX Dashboard ver
3.0 2.16.x
2.15 2.15.x
2.14 2.14.x
..... .....

Agree

@Baoyuantop Baoyuantop merged commit 8c9b7bc into apache:master Jan 27, 2023
@Baoyuantop Baoyuantop deleted the release-300 branch January 27, 2023 03:50
Baoyuantop added a commit that referenced this pull request Jan 28, 2023
@Baoyuantop
Revert "feat: release 2.16.0 (#2719)"
2eff209 
This reverts commit 8c9b7bc.
@Baoyuantop Baoyuantop mentioned this pull request Jan 28, 2023
Merged
Baoyuantop added a commit that referenced this pull request Jan 28, 2023
@Baoyuantop
Revert "feat: release 2.16.0 (#2719)" (#2721)
7ce75b9 
This reverts commit 8c9b7bc.
hongbinhsu added a commit to fitphp/apix-dashboard that referenced this pull request Jan 30, 2023
@hongbinhsu
Merge branch 'upstream/master' into github/master
ba48f8d 
* upstream/master:
  feat: release 3.0.0 (apache#2722)
  Revert "feat: release 2.16.0 (apache#2719)" (apache#2721)
  feat: release 2.16.0 (apache#2719)
  fix: plugin configuration lost in editor (apache#2718)
  fix: adapt APISIX plugin disabled (apache#2717)
  feat: basic support Apache APISIX 3.0.0 (apache#2701)
  feat: change etcd prefix for ssl and proto (apache#2693)
  fix: remove cases external service dependency (apache#2697)
  chore: simplify e2e environment (apache#2694)
  chore: optimize "allow_origins_by_regex tooltip" description (apache#2690)
  feat: release 2.15.0 (apache#2685)
  feat: basic support Apache APISIX 2.15.0 (apache#2680)
  feat: release 2.14.0 (apache#2677)
  fix: bump go version to 1.16 (apache#2678)
  feat: release 2.13.1 (apache#2658)
  feat: support more upstream scheme (apache#2675)
  feat: support purge method (apache#2674)
  feat: add enable flag to oidc function (apache#2672)

# Conflicts:
#	web/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoqqqi guoqqqi guoqqqi approved these changes

@SkyeYoung SkyeYoung SkyeYoung approved these changes

@bzp2010 bzp2010 bzp2010 approved these changes

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@LiteSun LiteSun Awaiting requested review from LiteSun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Baoyuantop @codecov-commenter @juzhiyuan @SkyeYoung @bzp2010 @guoqqqi