Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Int96Converter Truncates Timestamps #2480

Closed
tustvold opened this issue Aug 17, 2022 · 0 comments · Fixed by #2481
Closed

Int96Converter Truncates Timestamps #2480

tustvold opened this issue Aug 17, 2022 · 0 comments · Fixed by #2481
Labels
bug parquet Changes to the parquet crate

Comments

@tustvold
Copy link
Contributor

tustvold commented Aug 17, 2022 •
edited
Loading

Describe the bug

Int96ArrayConverter takes the INT96 data and converts it to an i64 number of milliseconds since epoch, it then multiplies this by 1_000_000 to convert to a i64 number of nanoseconds since epoch. This loses the nanosecond precision contained within the INT96 data

To Reproduce

Expected behavior

Additional context

Noticed whilst playing with #1661
@tustvold tustvold added the bug label Aug 17, 2022
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 17, 2022
@tustvold
Remove Int96Converter (apache#2480)
9ad9543
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 17, 2022
@tustvold
Remove Int96Converter (apache#2480)
dba2287
@tustvold tustvold mentioned this issue Aug 17, 2022
Merged
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 17, 2022
@tustvold
Remove Int96Converter (apache#2480)
93e4516
tustvold added a commit to tustvold/arrow-rs that referenced this issue Aug 19, 2022
@tustvold
Remove DecimalByteArrayConvert (apache#2480)
ac45077
@tustvold tustvold mentioned this issue Aug 19, 2022
Merged
tustvold added a commit that referenced this issue Aug 21, 2022
@tustvold
Remove DecimalByteArrayConvert (#2480) (#2522)
34216d5 
* Remove DecimalByteArrayConvert (#2480)

* Clippy
tustvold added a commit that referenced this issue Aug 22, 2022
@tustvold
Remove Int96Converter (#2480) (#2481)
faaab55 
* Remove Int96Converter (#2480)

* Format
@alamb alamb added the parquet Changes to the parquet crate label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Int96Converter (#2480) tustvold/arrow-rs
2 participants
@alamb @tustvold