Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Int96Converter (#2480) #2481

Merged
merged 6 commits into from
Aug 22, 2022
Merged

Remove Int96Converter (#2480) #2481

merged 6 commits into from
Aug 22, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Aug 17, 2022 •
edited
Loading

Which issue does this PR close?

Closes #2480
Closes #982
Part of #1661

Rationale for this change

We want to remove ComplexObjectArrayReader (#1661) and the previous implementation was incorrect (#2480). Lets fix both by moving to read Int96 as a Primitive.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Aug 17, 2022
@tustvold tustvold force-pushed the remove-int96-converter branch from dba2287 to 93e4516 Compare August 17, 2022 16:08
@tustvold tustvold marked this pull request as ready for review August 17, 2022 16:08
This was referenced Aug 19, 2022
Closed
Merged
tustvold
tustvold commented Aug 19, 2022
View reviewed changes
parquet/src/arrow/array_reader/primitive_array.rs
boolean_buffer.finish()
}
PhysicalType::INT96 => {
// SAFETY - record_data is an aligned buffer of Int96
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once ComplexObjectArrayReader is gone, I intend to see if we can rework the parquet decoder plumbing to avoid this hackery

@tustvold tustvold requested a review from liukun4515 August 21, 2022 08:15
@tustvold tustvold merged commit faaab55 into apache:master Aug 22, 2022
@ursabot
Copy link

ursabot commented Aug 22, 2022

Benchmark runs are scheduled for baseline = dc1448e and contender = faaab55. faaab55 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liukun4515 liukun4515 liukun4515 approved these changes

Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
3 participants
@tustvold @ursabot @liukun4515