Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non utf8 values into the test cases of BinaryArray comparison #1220

Merged

Conversation

HaoYang670
Copy link
Contributor

@HaoYang670 HaoYang670 commented Jan 22, 2022

Which issue does this PR close?

Re #1108

Rationale for this change

What changes are included in this PR?

This is a follow-on PR of #1195.
In this PR, we add non utf8 value into test cases of BinaryArray comparison.

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1220 (2ce808f) into master (0377aae) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
- Coverage   82.71%   82.70%   -0.01%     
==========================================
  Files         175      175              
  Lines       51711    51711              
==========================================
- Hits        42771    42770       -1     
- Misses       8940     8941       +1     
Impacted Files Coverage Δ
arrow/src/compute/kernels/comparison.rs 91.96% <100.00%> (ø)
arrow/src/datatypes/field.rs 53.79% <0.00%> (-0.31%) ⬇️
arrow/src/array/transform/mod.rs 85.56% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0377aae...2ce808f. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @HaoYang670

@alamb alamb merged commit 66e029e into apache:master Jan 23, 2022
@HaoYang670 HaoYang670 deleted the issue1108_add_comparison_for_BinaryArray branch January 25, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants