-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non utf8 values into the test cases of BinaryArray comparison #1220
Add non utf8 values into the test cases of BinaryArray comparison #1220
Conversation
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
delete dyn comparison which will be added in successive PRs Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Signed-off-by: remzi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1220 +/- ##
==========================================
- Coverage 82.71% 82.70% -0.01%
==========================================
Files 175 175
Lines 51711 51711
==========================================
- Hits 42771 42770 -1
- Misses 8940 8941 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @HaoYang670
Which issue does this PR close?
Re #1108
Rationale for this change
What changes are included in this PR?
This is a follow-on PR of #1195.
In this PR, we add non utf8 value into test cases of BinaryArray comparison.
Are there any user-facing changes?