Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non utf8 values into the test cases of BinaryArray comparison #1220

Merged
merged 10 commits into from
Jan 23, 2022
Merged

Add non utf8 values into the test cases of BinaryArray comparison #1220

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2795501
add eq_dyn for BinaryArray
HaoYang670 Jan 17, 2022
8b066d7
correct the code formatting
HaoYang670 Jan 17, 2022
fccc0f9
add comparison support for fully qualified binary array
HaoYang670 Jan 17, 2022
7921d4b
add tests for comparison of fully qualified BinaryArray
HaoYang670 Jan 18, 2022
6de06d9
add 2 missed tests
HaoYang670 Jan 18, 2022
5f1b3fe
move 2 functions
HaoYang670 Jan 18, 2022
05619e3
fix reference error
HaoYang670 Jan 19, 2022
ff3ab90
Merge branch 'master' into issue1108_add_comparison_for_BinaryArray
HaoYang670 Jan 19, 2022
c4e5121
add non utf8 bytes to the test cases of BinaryArray comparision
HaoYang670 Jan 22, 2022
2ce808f
merge master
HaoYang670 Jan 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions arrow/src/compute/kernels/comparison.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2972,86 +2972,86 @@ mod tests {

test_binary!(
test_binary_array_eq,
vec![b"arrow", b"arrow", b"arrow", b"arrow"],
vec![b"arrow", b"parquet", b"datafusion", b"flight"],
vec![b"arrow", b"arrow", b"arrow", b"arrow", &[0xff, 0xf8]],
vec![b"arrow", b"parquet", b"datafusion", b"flight", &[0xff, 0xf8]],
eq_binary,
vec![true, false, false, false]
vec![true, false, false, false, true]
);

test_binary_scalar!(
test_binary_array_eq_scalar,
vec![b"arrow", b"parquet", b"datafusion", b"flight"],
vec![b"arrow", b"parquet", b"datafusion", b"flight", &[0xff, 0xf8]],
"arrow".as_bytes(),
eq_binary_scalar,
vec![true, false, false, false]
vec![true, false, false, false, false]
);

test_binary!(
test_binary_array_neq,
vec![b"arrow", b"arrow", b"arrow", b"arrow"],
vec![b"arrow", b"parquet", b"datafusion", b"flight"],
vec![b"arrow", b"arrow", b"arrow", b"arrow", &[0xff, 0xf8]],
vec![b"arrow", b"parquet", b"datafusion", b"flight", &[0xff, 0xf9]],
neq_binary,
vec![false, true, true, true]
vec![false, true, true, true, true]
);
test_binary_scalar!(
test_binary_array_neq_scalar,
vec![b"arrow", b"parquet", b"datafusion", b"flight"],
vec![b"arrow", b"parquet", b"datafusion", b"flight", &[0xff, 0xf8]],
"arrow".as_bytes(),
neq_binary_scalar,
vec![false, true, true, true]
vec![false, true, true, true, true]
);

test_binary!(
test_binary_array_lt,
vec![b"arrow", b"datafusion", b"flight", b"parquet"],
vec![b"flight", b"flight", b"flight", b"flight"],
vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff, 0xf8]],
vec![b"flight", b"flight", b"flight", b"flight", &[0xff, 0xf9]],
lt_binary,
vec![true, true, false, false]
vec![true, true, false, false, true]
);
test_binary_scalar!(
test_binary_array_lt_scalar,
vec![b"arrow", b"datafusion", b"flight", b"parquet"],
vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff, 0xf8]],
"flight".as_bytes(),
lt_binary_scalar,
vec![true, true, false, false]
vec![true, true, false, false, false]
);

test_binary!(
test_binary_array_lt_eq,
vec![b"arrow", b"datafusion", b"flight", b"parquet"],
vec![b"flight", b"flight", b"flight", b"flight"],
vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff, 0xf8]],
vec![b"flight", b"flight", b"flight", b"flight", &[0xff, 0xf8, 0xf9]],
lt_eq_binary,
vec![true, true, true, false]
vec![true, true, true, false, true]
);
test_binary_scalar!(
test_binary_array_lt_eq_scalar,
vec![b"arrow", b"datafusion", b"flight", b"parquet"],
vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff, 0xf8]],
"flight".as_bytes(),
lt_eq_binary_scalar,
vec![true, true, true, false]
vec![true, true, true, false, false]
);

test_binary!(
test_binary_array_gt,
vec![b"arrow", b"datafusion", b"flight", b"parquet"],
vec![b"flight", b"flight", b"flight", b"flight"],
vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff, 0xf9]],
vec![b"flight", b"flight", b"flight", b"flight", &[0xff, 0xf8]],
gt_binary,
vec![false, false, false, true]
vec![false, false, false, true, true]
);
test_binary_scalar!(
test_binary_array_gt_scalar,
vec![b"arrow", b"datafusion", b"flight", b"parquet"],
vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff, 0xf8]],
"flight".as_bytes(),
gt_binary_scalar,
vec![false, false, false, true]
vec![false, false, false, true, true]
);

test_binary!(
test_binary_array_gt_eq,
vec![b"arrow", b"datafusion", b"flight", b"parquet"],
vec![b"flight", b"flight", b"flight", b"flight"],
vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff, 0xf8]],
vec![b"flight", b"flight", b"flight", b"flight", &[0xff, 0xf8]],
gt_eq_binary,
vec![false, false, true, true]
vec![false, false, true, true, true]
);
test_binary_scalar!(
test_binary_array_gt_eq_scalar,
Expand Down