-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin version to grpcio in build-requirements.txt #23735
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23735 +/- ##
==========================================
- Coverage 73.23% 73.22% -0.01%
==========================================
Files 719 719
Lines 95962 95967 +5
==========================================
- Hits 70277 70273 -4
- Misses 24373 24382 +9
Partials 1312 1312
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sdks/python/build-requirements.txt
Outdated
@@ -21,6 +21,9 @@ setuptools | |||
wheel>=0.36.0 | |||
|
|||
grpcio-tools==1.37.0 | |||
# TODO(https://github.com/apache/beam/issues/23734): the sdist for grpcio==1.50.0 is failing on GH workers | |||
# pin grpcio to the previous version. | |||
grpcio==1.49.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we pick the same version for grpcio and grpcio-tools? (We should probably do it at the beginning...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the consequence if the version between the both differ?
IIUC, grpcio-tools==1.37.0 has a requirement of grpcio>=1.37.0. I think having a version equal to or greater than grpcio-tools for grpcio would be fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we do this pinning for the mac platform only? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
LGTM |
remaining tests should be not affected by this change. |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.