Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin version to grpcio in build-requirements.txt #23735

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Pin version to grpcio in build-requirements.txt #23735

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac5c03c
Pin version to grpcio
AnandInguva Oct 19, 2022
1da6133
Pin version only for MacOS
AnandInguva Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sdks/python/build-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ setuptools
wheel>=0.36.0

grpcio-tools==1.37.0
# TODO(https://github.com/apache/beam/issues/23734): the sdist for grpcio==1.50.0 is failing on GH workers
# pin grpcio to the previous version.
grpcio==1.49.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pick the same version for grpcio and grpcio-tools? (We should probably do it at the beginning...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the consequence if the version between the both differ?

IIUC, grpcio-tools==1.37.0 has a requirement of grpcio>=1.37.0. I think having a version equal to or greater than grpcio-tools for grpcio would be fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do this pinning for the mac platform only? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

mypy-protobuf==1.18
protobuf==3.19.4;python_version=="3.10" and sys_platform=="darwin"

Expand Down