Upgrade to sqlparser 0.53.0
#13767
Draft
Upgrade to sqlparser 0.53.0
#13767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
force-pushed
the
alamb/sqlparser_0.53.0
branch
from
6dc5055 to
3e521f1
Compare
alamb
commented
Dec 14, 2024
| @@ -200,7 +204,6 @@ impl<S: ContextProvider> SqlToRel<'_, S> { | |||
| statement: Statement, | |||
| planner_context: &mut PlannerContext, | |||
| ) -> Result<LogicalPlan> { | |||
| let sql = Some(statement.to_string()); | |||
There was a problem hiding this comment.
This change was needed because otherwise tpcds_logical_q64 overflowed its stack
https://github.com/apache/datafusion/actions/runs/12322166828/job/34395679472?pr=13767
thread 'tpcds_logical_q64' has overflowed its stack
fatal runtime error: stack overflow
error: test failed, to rerun pass `-p datafusion --test tpcds_planning`
I traced it down locally and apparently trying to format the deeply nested query was actually overflowing at this spot.
alamb
commented
Dec 14, 2024
| @@ -514,6 +517,35 @@ impl<S: ContextProvider> SqlToRel<'_, S> { | |||
| return not_impl_err!("To not supported")?; | |||
| } | |||
|
|
|||
| // put the statement back together temporarily to get the SQL | |||
There was a problem hiding this comment.
While this formulation is more code, it does avoid serializing the entire input string on every query, even when it is not needed
| @@ -313,7 +313,7 @@ pub enum Expr { | |||
| /// plan into physical plan. | |||
| Wildcard { | |||
| qualifier: Option<TableReference>, | |||
| options: WildcardOptions, | |||
| options: Box<WildcardOptions>, | |||
There was a problem hiding this comment.
This was needed to avoid a clippy lint about enum variants being too different. Specifically sqlparser added some new fields to WildCardOptions which made them substantially larger
alamb
force-pushed
the
alamb/sqlparser_0.53.0
branch
from
239c18e to
1e8d072
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft until sqlparser is released:
0.53.0/ sqlparser_derive0.3.0datafusion-sqlparser-rs#1517Which issue does this PR close?
Rationale for this change
Keep up with dependencies (in this case get access to source spans)
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?