-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert #6595 #6820 #6827
revert #6595 #6820 #6827
Conversation
|
14d75b7
to
3224f44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs some tests given that we didn't catch it initially, so we don't know if this code is covered or not.
I will contribute some shortly
BTW here are some tests (that I verified that this PR fixes the errors): #6836 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jackwener
Thanks @alamb |
* revert: from_plan keep same schema Project in apache#6595 * revert: from_plan keep same schema Agg/Window in apache#6820 * revert type coercion * add comment
* revert: from_plan keep same schema Project in apache#6595 * revert: from_plan keep same schema Agg/Window in apache#6820 * revert type coercion * add comment
Which issue does this PR close?
Closes #6819 #6790 .
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?