Add clickbench queries to sqllogictest coverage #6836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
Merged
alamb
commented
Jul 3, 2023
| SELECT "AdvEngineID", COUNT(*) FROM hits WHERE "AdvEngineID" <> 0 GROUP BY "AdvEngineID" ORDER BY COUNT(*) DESC; | ||
| ---- | ||
|
|
||
| # https://github.com/apache/arrow-datafusion/issues/6790 |
There was a problem hiding this comment.
These are fixed by #6827
Dandandan
reviewed
Jul 3, 2023
Co-authored-by: Daniël Heres <[email protected]>
Dandandan
reviewed
Jul 4, 2023
There was a problem hiding this comment.
Can we rename datafusion/core/tests/data/clickbench_hits_10.parqet as well to parquet? Otherwise looks good :)
|
oh man, of course |
Dandandan
approved these changes
Jul 5, 2023
2010YOUY01
pushed a commit
to 2010YOUY01/arrow-datafusion
that referenced
this pull request
Jul 5, 2023
* Add clickbench queries to sqllogictest coverage * rowsort * Update datafusion/core/tests/sqllogictests/test_files/clickbench.slt Co-authored-by: Daniël Heres <[email protected]> * fix typo -- 🤦 * Update queries now that they pass --------- Co-authored-by: Daniël Heres <[email protected]>
alamb
added a commit
to alamb/datafusion
that referenced
this pull request
Jul 6, 2023
* Add clickbench queries to sqllogictest coverage * rowsort * Update datafusion/core/tests/sqllogictests/test_files/clickbench.slt Co-authored-by: Daniël Heres <[email protected]> * fix typo -- 🤦 * Update queries now that they pass --------- Co-authored-by: Daniël Heres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #6790
Closes #6790 (via test)
Rationale for this change
I would like test coverage for changes in #6827 (especially as it caused a regression that we didn't catch)
I also would like to ensure we don't break clickbench again
What changes are included in this PR?
Are these changes tested?
They are ONLY tests
Are there any user-facing changes?
No