Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-18674: Document the incompatible changes in parsing --bootstrap-server #18751

Conversation

mingyen066
Copy link
Contributor

@mingyen066 mingyen066 commented Jan 30, 2025

Based on the discussion of #18741 (comment), add the description to docs/upgrade.html

The change in behavior requiring strict validation seems reasonable for 4.0 so we probably ought to mention it in the documentation in docs/upgrade.html.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community docs small Small PRs labels Jan 30, 2025
docs/upgrade.html Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the triage PRs from the community label Jan 31, 2025
@kamalcph kamalcph changed the title KAFKA-18674: Document the incompatible changes in parsing --bootstrap.servers KAFKA-18674: Document the incompatible changes in parsing --bootstrap-server Jan 31, 2025
@chia7712
Copy link
Member

chia7712 commented Feb 3, 2025

@mingyen066 could you please copy the unit test of #18767 to 4.0? the other format should be failed in 4.0

@mingyen066
Copy link
Contributor Author

Hi @chia7712 , absolutely! I've created PR #18781, which includes a unit test for verify invalid format in 4.0. PTAL. Thank you!"

@chia7712 chia7712 merged commit 9d6faf0 into apache:trunk Feb 3, 2025
10 checks passed
chia7712 pushed a commit that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants