KAFKA-18675: Add unit test to verify space separated brokers won't cause exception for 3.8 and 3.9 #18767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingyen066
changed the title
frankvicky
reviewed
Feb 2, 2025
clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java
Outdated
Show resolved
Hide resolved
clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java
Outdated
Show resolved
Hide resolved
clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java
Outdated
Show resolved
Hide resolved
|
The failed test cases |
chia7712
reviewed
Feb 3, 2025
3 tasks
3 tasks
chia7712
approved these changes
Feb 4, 2025
chia7712
reviewed
Feb 4, 2025
There was a problem hiding this comment.
@mingyen066 thanks for this patch. a couple of comments remains.
| static Stream<List<String>> provideInvalidBrokerAddressTestCases() { | ||
| return Stream.of( | ||
| Collections.singletonList("localhost:9997\nlocalhost:9998\nlocalhost:9999"), | ||
| Collections.singletonList("localhost:10000") |
There was a problem hiding this comment.
localhost:10000 is valid, and the test can cause "expected" error due to "random.value"
m1a2st
reviewed
Feb 4, 2025
clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java
Outdated
Show resolved
Hide resolved
chia7712
pushed a commit
that referenced
this pull request
Feb 5, 2025
…se exception for 3.8 and 3.9 (#18767) Reviewers: Ken Huang <[email protected]>, TengYao Chi <[email protected]>, Chia-Ping Tsai <[email protected]>
mingyen066
deleted the
KAFKA-18675-Add-unit-tests-for-KAFKA-18171-to-verify-the-parser-of-bootstrap.servers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion #18741 (comment)
Add unit test to ensure user can provide space-separated broker list
This change need to be backported to 3.8 as well
Committer Checklist (excluded from commit message)