Added option to set the method name for Basic authentication #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
approved these changes
Oct 11, 2022
Co-authored-by: Yunze Xu <[email protected]>
nodece
approved these changes
Oct 11, 2022
|
Do we need to extend the |
Yes, we can add it later. Just want to get this included in the release and python too. |
merlimat
added a commit
that referenced
this pull request
Oct 11, 2022
* Added option to set the method name for Basic authentication * Fixes * Added more tests * Update lib/auth/AuthBasic.cc Co-authored-by: Yunze Xu <[email protected]> Co-authored-by: Yunze Xu <[email protected]>
BewareMyPower
added a commit
to BewareMyPower/pulsar-client-python
that referenced
this pull request
Oct 13, 2022
### Motivation apache/pulsar#17482 supported basic authentication for Python client, but the `AuthenticationBasic` class accepts two positional arguments as the username and password. It's not good for extension. We should accept an auth param string like `AuthenticationOauth2` so that no changes are needed if the upstream C++ client's implementation changed, like apache/pulsar-client-cpp#37. ### Modifications To be compatible with the existing API, change the first two arguments to keyword arguments. Then, add the 3rd keyword argument to represent the auth param string. ### Verifications `test_basic_auth` and `test_invalid_basic_auth` are extended for this change.
merlimat
pushed a commit
to apache/pulsar-client-python
that referenced
this pull request
Oct 13, 2022
* Support auth param string for Basic authentication ### Motivation apache/pulsar#17482 supported basic authentication for Python client, but the `AuthenticationBasic` class accepts two positional arguments as the username and password. It's not good for extension. We should accept an auth param string like `AuthenticationOauth2` so that no changes are needed if the upstream C++ client's implementation changed, like apache/pulsar-client-cpp#37. ### Modifications To be compatible with the existing API, change the first two arguments to keyword arguments. Then, add the 3rd keyword argument to represent the auth param string. ### Verifications `test_basic_auth` and `test_invalid_basic_auth` are extended for this change. * Add method argument and related tests * Add type check for method arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Added option to set the method name for Basic authentication