[feat][python] Add basic authentication #17482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
github-actions
bot
added
the
doc-required
Signed-off-by: Zixuan Liu <[email protected]>
nodece
force-pushed
the
python-basic-auth
branch
from
64210f3 to
3369668
Compare
BewareMyPower
requested review from
codelipenghui,
gaoran10,
merlimat,
RobertIndie,
tuteng and
Demogorgon314
BewareMyPower
requested changes
Sep 6, 2022
RobertIndie
approved these changes
Sep 6, 2022
|
#15822 has merged to branch-2.11. It's good to have this one in 2.11.0 |
Signed-off-by: Zixuan Liu <[email protected]>
I added this test, please help review, thanks! |
BewareMyPower
approved these changes
Sep 6, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Sep 7, 2022
(cherry picked from commit eae90f6)
momo-jun
added a commit
to momo-jun/pulsar
that referenced
this pull request
Sep 14, 2022
1 task
momo-jun
removed
the
doc-required
momo-jun
added
the
doc-complete
momo-jun
added a commit
that referenced
this pull request
Sep 20, 2022
…hapter (#17615) * Sidebar re-org * Separate TLS encryption/authentication using Keystore to parent topics * use language-specific tabs to show code snippets * streamline headings * Update client-libraries-java.md * Add code snippet for python clients to support #17482 * Add code snippet for go clients
BewareMyPower
added a commit
to BewareMyPower/pulsar-client-python
that referenced
this pull request
Oct 13, 2022
### Motivation apache/pulsar#17482 supported basic authentication for Python client, but the `AuthenticationBasic` class accepts two positional arguments as the username and password. It's not good for extension. We should accept an auth param string like `AuthenticationOauth2` so that no changes are needed if the upstream C++ client's implementation changed, like apache/pulsar-client-cpp#37. ### Modifications To be compatible with the existing API, change the first two arguments to keyword arguments. Then, add the 3rd keyword argument to represent the auth param string. ### Verifications `test_basic_auth` and `test_invalid_basic_auth` are extended for this change.
merlimat
pushed a commit
to apache/pulsar-client-python
that referenced
this pull request
Oct 13, 2022
* Support auth param string for Basic authentication ### Motivation apache/pulsar#17482 supported basic authentication for Python client, but the `AuthenticationBasic` class accepts two positional arguments as the username and password. It's not good for extension. We should accept an auth param string like `AuthenticationOauth2` so that no changes are needed if the upstream C++ client's implementation changed, like apache/pulsar-client-cpp#37. ### Modifications To be compatible with the existing API, change the first two arguments to keyword arguments. Then, add the 3rd keyword argument to represent the auth param string. ### Verifications `test_basic_auth` and `test_invalid_basic_auth` are extended for this change. * Add method argument and related tests * Add type check for method arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Python misses the basic authentication.
Verifying this change
Added
test_basic_authtest to cover this feature.Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-requiredAdd Python basic authentication documentation.
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)