-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of powermock #16912
Comments
I think we can simply modify the access modifiers, and mark |
@shoothzj IIUC do you suggest a replacement of powermock here? |
@tisonkun Yes, I suggest to replace powermock. Using |
@shoothzj thank you. I'll consider this approach when protptyping. There're some cases we try to hijack third-party lib's field, like But yes, we can use multiple alternatives properly in each concrete case. |
I draft an incompleted patch on #16997. However, I notice that there's some code we hack in "set final" field, like: pulsar/pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java Lines 1071 to 1072 in 21634ed
.. or even "set static final" field, like: Line 111 in 21634ed
It seems |
…7022) Master Issue: #16912 - [x] `doc-not-needed` cc @shoothzj @eolivelli @nicoloboschi @Technoboy- Signed-off-by: tison <[email protected]>
Master Issue: #16912 - [x] `doc-not-needed` cc @shoothzj @eolivelli @nicoloboschi @Technoboy-
Master Issue: apache#16912 - [x] `doc-not-needed` cc @shoothzj @eolivelli @nicoloboschi @Technoboy-
Master Issue: #16912 Remove `WhiteBox` usage in `pulsar-client` and `pulsar-client-tools`. We then have only usages in `pulsar-broker`, `pulsar-io-elastic-search`, and `testmocks`. cc @nicoloboschi @lhotari @shoothzj @eolivelli ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [x] `doc-not-needed` (Please explain why) - [ ] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added)
Master Issue: #16912 ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [x] `doc-not-needed` (Please explain why) - [ ] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added)
…7022) Master Issue: #16912 - [x] `doc-not-needed` cc @shoothzj @eolivelli @nicoloboschi @Technoboy- Signed-off-by: tison <[email protected]>
) Master Issue: apache#16912 ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [x] `doc-not-needed` (Please explain why) - [ ] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added)
) Master Issue: apache#16912 <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [x] `doc-not-needed` (Please explain why) - [ ] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added) (cherry picked from commit adb63d8)
…7022) Master Issue: #16912 - [x] `doc-not-needed` cc @shoothzj @eolivelli @nicoloboschi @Technoboy- Signed-off-by: tison <[email protected]> (cherry picked from commit 7747795)
…ache#17022) Master Issue: apache#16912 - [x] `doc-not-needed` cc @shoothzj @eolivelli @nicoloboschi @Technoboy- Signed-off-by: tison <[email protected]> (cherry picked from commit 7747795) (cherry picked from commit 35097fd)
…ache#17022) Master Issue: apache#16912 - [x] `doc-not-needed` cc @shoothzj @eolivelli @nicoloboschi @Technoboy- Signed-off-by: tison <[email protected]> (cherry picked from commit 7747795) (cherry picked from commit 35097fd)
Master Issue: #16912 ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc-required` (Your PR needs to update docs and you will update later) - [x] `doc-not-needed` (Please explain why) - [ ] `doc` (Your PR contains doc changes) - [ ] `doc-complete` (Docs have been already added)
In this comment #16884 (comment) I wrote:
Thus I file this issue to investigate whether we can remove powermock from our testing framework.
WDTY @merlimat @lhotari @codelipenghui @nicoloboschi?
The text was updated successfully, but these errors were encountered: