Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slowly-test: TransactionEndToEndWithoutBatchIndexAckTest #17637

Closed
1 of 2 tasks
Tracked by #17657
poorbarcode opened this issue Sep 14, 2022 · 0 comments
Closed
1 of 2 tasks
Tracked by #17657

slowly-test: TransactionEndToEndWithoutBatchIndexAckTest #17637

poorbarcode opened this issue Sep 14, 2022 · 0 comments

Comments

@poorbarcode
Copy link
Contributor

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

This test run took more than 5 minutes

截屏2022-09-14 15 03 48

https://github.com/apache/pulsar/actions/runs/3046366380/jobs/4910018507

Solution

Make the test run faster

Alternatives

No response

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
congbobo184 pushed a commit that referenced this issue Sep 28, 2022
…on time (#17790)

Fixes
- #17623
- #17637

### Motivation

Manually release resources, including `consumer`, `producer`, `pulsar client`, `transaction`, and `topic`. This saves `setup` and `cleanup` time before and after each method. 

### Modifications

- Manually release resources instead of calling `cleanup` & `setup` each method
- remove useless method `markDeletePositionCheck`
- `Integer.valueOf(int)` instead of `new Integer(int)`, because `new Integer(int)` is deprecated

### Matching PR in forked repository

PR in forked repository: 

- poorbarcode#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant