Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][test] Improve TransactionEndToEndTest to reduce the execution time #17790

Merged
merged 2 commits into from
Sep 28, 2022
Merged

[improve][test] Improve TransactionEndToEndTest to reduce the execution time #17790

merged 2 commits into from
Sep 28, 2022

Conversation

poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented Sep 22, 2022 •
edited
Loading

Fixes

Motivation

Manually release resources, including consumer, producer, pulsar client, transaction, and topic. This saves setup and cleanup time before and after each method.

Modifications

  • Manually release resources instead of calling cleanup & setup each method
  • remove useless method markDeletePositionCheck
  • Integer.valueOf(int) instead of new Integer(int), because new Integer(int) is deprecated

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Matching PR in forked repository

PR in forked repository:

@poorbarcode poorbarcode changed the title [improve][test] Improve TransactionEndToEndTest to reduce the executi… [improve][test] Improve TransactionEndToEndTest to reduce the execution time Sep 22, 2022
@poorbarcode poorbarcode mentioned this pull request Sep 22, 2022
Closed
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 22, 2022
@poorbarcode poorbarcode mentioned this pull request Sep 23, 2022
Closed
4 tasks
@congbobo184 congbobo184 added this to the 2.11.0 milestone Sep 27, 2022
liangyepianzhou
liangyepianzhou approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@liangyepianzhou liangyepianzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work！

@poorbarcode poorbarcode reopened this Sep 28, 2022
@congbobo184 congbobo184 merged commit 7648a11 into apache:master Sep 28, 2022
@poorbarcode poorbarcode deleted the slow/TransactionEndToEndTest branch September 28, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangyepianzhou liangyepianzhou liangyepianzhou approved these changes

@congbobo184 congbobo184 congbobo184 approved these changes

@gaoran10 gaoran10 Awaiting requested review from gaoran10

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

Assignees

@poorbarcode poorbarcode

Labels
doc-not-needed Your PR changes do not impact docs type/flaky-tests
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@poorbarcode @congbobo184 @liangyepianzhou