Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 14013][broker] make getInternalStats method async #14047

Closed
wants to merge 1 commit into from

Conversation

HQebupt
Copy link
Contributor

@HQebupt HQebupt commented Jan 29, 2022

Master Issue: #14013

Motivation

See #14013

Verifying this change

Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 29, 2022
Copy link
Member

@mattisonchao mattisonchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1.
but I have two suggestions:

Remove asyncResponse from the internal method, and unified exception and result handling are performed at the controller layer, which makes the internal method purer.
Have you checked to see if there is a test for the modified method ?

Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please fix test failure.

@HQebupt
Copy link
Contributor Author

HQebupt commented Jan 30, 2022

/pulsarbot rerun-failure-checks

@github-actions
Copy link

github-actions bot commented Mar 2, 2022

The pr had no activity for 30 days, mark with Stale label.

@Jason918
Copy link
Contributor

Jason918 commented Mar 2, 2022

@HQebupt Please resolve the test failure.

@HQebupt
Copy link
Contributor Author

HQebupt commented Mar 6, 2022

/pulsarbot rerun-failure-checks

@HQebupt
Copy link
Contributor Author

HQebupt commented Apr 2, 2022

/pulsarbot rerun-failure-checks

@lhotari
Copy link
Member

lhotari commented Apr 2, 2022

Please don't rerun failed checks. That won't make the tests pass since this PR contains outdated GitHub Actions workflow changes. You must rebase this PR, push new commits or merge master branch changes to it. Please check the dev mailing list for more information.

@HQebupt
Copy link
Contributor Author

HQebupt commented Apr 2, 2022

Please don't rerun failed checks. That won't make the tests pass since this PR contains outdated GitHub Actions workflow changes. You must rebase this PR, push new commits or merge master branch changes to it. Please check the dev mailing list for more information.

Got it. Thx Lari @lhotari

@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@HQebupt HQebupt closed this Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs lifecycle/stale Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants