-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PersistentTopicsBase some methods async #14013
Comments
getPermissionsOnTopic |
I can fix some @Technoboy- |
Thanks for your help. assigned. |
Hi, I can fix some @Technoboy- |
I can fix some of them. @liudezhi2098 |
@mattisonchao Can I fix getStats and getInternalStats ? Thanks in advance. |
@Technoboy- Current |
Motivation See apache#14013 Modification * Make PersistentTopicsBase#internalExamineMessage async Signed-off-by: Zike Yang <[email protected]>
Motivation See apache#14013 Modification * Make PersistentTopicsBase#terminate async Signed-off-by: Zike Yang <[email protected]>
Motivation See apache#14013 Modification * Make PersistentTopicsBase#internalCompactionStatus async Signed-off-by: Zike Yang <[email protected]>
Motivation See apache#14013 Modification * Make PersistentTopicsBase#internalDeleteTopic async Signed-off-by: Zike Yang <[email protected]>
Motivation See apache#14013 Modification * Make PersistentTopicsBase#internalDeleteTopic async Signed-off-by: Zike Yang <[email protected]>
@Technoboy- @codelipenghui @merlimat Why are these changes made? The issue description doesn't describe any problem, just a decision. Since there are a lot of these sync -> async changes, it would be good to always open a discussion on the dev-mailing list to get a consensus of the problem that is being solved. In Apache Pulsar, we make all major decisions on the mailing list. @Technoboy- Could you start a dev-mailing list thread on the topic which describes the problem, the assumptions and the solution? /cc @mattisonchao |
I didn't receive a reply to my questions. I have taken these sync->async changes to discussion on the mailing list in the 2.10.0 release thread. https://lists.apache.org/thread/ggsywqsvwpb1yw8wh490mp8mbgzgxch5 . |
@codelipenghui Thank you for replying on the mailing list in thread https://lists.apache.org/thread/tn7rt59cd1k724l4ytfcmzx1w2sbtw7l . I have followed up with PR #14320 . |
Hi, @lhotari , I have opened a DISCUSS #14365 for this. Sorry for the late response. |
The issue had no activity for 30 days, mark with Stale label. |
The issue had no activity for 30 days, mark with Stale label. |
All the tracked methods have been resolved. |
Motivation
PersistentTopicsBase has some sync methods. Decide to make them async.
Volunteers wanted for this.
Methods
PersistentTopics#getPartitionedTopicList
to pure async. #14059The text was updated successfully, but these errors were encountered: