Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PersistentTopicsBase some methods async #14013

Closed
18 of 19 tasks
Technoboy- opened this issue Jan 28, 2022 · 15 comments
Closed
18 of 19 tasks

Make PersistentTopicsBase some methods async #14013

Technoboy- opened this issue Jan 28, 2022 · 15 comments
Labels
lifecycle/stale Stale type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Comments

@Technoboy-
Copy link
Contributor

Technoboy- commented Jan 28, 2022

Motivation

PersistentTopicsBase has some sync methods. Decide to make them async.
Volunteers wanted for this.

Methods

@Technoboy- Technoboy- added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Jan 28, 2022
@liudezhi2098
Copy link
Contributor

getPermissionsOnTopic
grantPermissionsOnTopic
revokePermissionsOnTopic
skipMessages
peekNthMessage

@HQebupt
Copy link
Contributor

HQebupt commented Jan 29, 2022

I can fix some @Technoboy-

@Technoboy-
Copy link
Contributor Author

I can fix some @Technoboy-

Thanks for your help. assigned.

@shibd
Copy link
Member

shibd commented Jan 29, 2022

Hi, I can fix some @Technoboy-

@HQebupt
Copy link
Contributor

HQebupt commented Jan 29, 2022

getPermissionsOnTopic
grantPermissionsOnTopic
revokePermissionsOnTopic
skipMessages
peekNthMessage

I can fix some of them. @liudezhi2098

@HQebupt
Copy link
Contributor

HQebupt commented Jan 29, 2022

@mattisonchao Can I fix getStats and getInternalStats ? Thanks in advance.

@shibd
Copy link
Member

shibd commented Jan 30, 2022

@Technoboy- Current getManagedLedgerInfo method are already async.

RobertIndie added a commit to RobertIndie/pulsar that referenced this issue Jan 30, 2022
Motivation
See apache#14013

Modification
* Make PersistentTopicsBase#internalExamineMessage async

Signed-off-by: Zike Yang <[email protected]>
RobertIndie added a commit to RobertIndie/pulsar that referenced this issue Jan 30, 2022
Motivation
See apache#14013

Modification
* Make PersistentTopicsBase#terminate async

Signed-off-by: Zike Yang <[email protected]>
RobertIndie added a commit to RobertIndie/pulsar that referenced this issue Jan 30, 2022
Motivation
See apache#14013
Modification
* Make PersistentTopicsBase#internalCompactionStatus async

Signed-off-by: Zike Yang <[email protected]>
RobertIndie added a commit to RobertIndie/pulsar that referenced this issue Jan 30, 2022
Motivation
See apache#14013
Modification
* Make PersistentTopicsBase#internalDeleteTopic async

Signed-off-by: Zike Yang <[email protected]>
RobertIndie added a commit to RobertIndie/pulsar that referenced this issue Jan 30, 2022
Motivation
See apache#14013
Modification
* Make PersistentTopicsBase#internalDeleteTopic async

Signed-off-by: Zike Yang <[email protected]>
@lhotari
Copy link
Member

lhotari commented Feb 9, 2022

PersistentTopicsBase has some sync methods. Decide to make them async.
Volunteers wanted for this.

@Technoboy- @codelipenghui @merlimat Why are these changes made? The issue description doesn't describe any problem, just a decision.

Since there are a lot of these sync -> async changes, it would be good to always open a discussion on the dev-mailing list to get a consensus of the problem that is being solved. In Apache Pulsar, we make all major decisions on the mailing list.

@Technoboy- Could you start a dev-mailing list thread on the topic which describes the problem, the assumptions and the solution? /cc @mattisonchao

@lhotari
Copy link
Member

lhotari commented Feb 15, 2022

I didn't receive a reply to my questions. I have taken these sync->async changes to discussion on the mailing list in the 2.10.0 release thread. https://lists.apache.org/thread/ggsywqsvwpb1yw8wh490mp8mbgzgxch5 .

@lhotari
Copy link
Member

lhotari commented Feb 16, 2022

@codelipenghui Thank you for replying on the mailing list in thread https://lists.apache.org/thread/tn7rt59cd1k724l4ytfcmzx1w2sbtw7l . I have followed up with PR #14320 .

@Technoboy-
Copy link
Contributor Author

PersistentTopicsBase has some sync methods. Decide to make them async.
Volunteers wanted for this.

@Technoboy- @codelipenghui @merlimat Why are these changes made? The issue description doesn't describe any problem, just a decision.

Since there are a lot of these sync -> async changes, it would be good to always open a discussion on the dev-mailing list to get a consensus of the problem that is being solved. In Apache Pulsar, we make all major decisions on the mailing list.

@Technoboy- Could you start a dev-mailing list thread on the topic which describes the problem, the assumptions and the solution? /cc @mattisonchao

Hi, @lhotari , I have opened a DISCUSS #14365 for this. Sorry for the late response.

@github-actions
Copy link

The issue had no activity for 30 days, mark with Stale label.

@github-actions
Copy link

The issue had no activity for 30 days, mark with Stale label.

@Technoboy-
Copy link
Contributor Author

All the tracked methods have been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Stale type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

No branches or pull requests

6 participants