[Broker] Make PersistentTopicsBase#internalDeleteTopic async #14069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation See apache#14013 Modification * Make PersistentTopicsBase#internalDeleteTopic async Signed-off-by: Zike Yang <[email protected]>
19 tasks
|
LGTM |
liangyuanpeng
previously approved these changes
Feb 3, 2022
nodece
reviewed
Feb 8, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Feb 8, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Feb 8, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Feb 8, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Feb 8, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Feb 8, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
|
Could we try to merge these two delete methods? |
nodece
reviewed
Feb 8, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
Show resolved
Hide resolved
nodece
reviewed
Feb 8, 2022
| response = mock(AsyncResponse.class); | ||
| persistentTopics.deleteTopic(response, testTenant, testNamespace, topicName, true, true, true); | ||
| verify(response, timeout(5000).times(1)).resume(errorCaptor.capture()); | ||
|
|
There was a problem hiding this comment.
Please check the errorCaptor.getValue(): has exception and instanceof RestException
There was a problem hiding this comment.
errorCaptor already checks that instance type.
nodece
reviewed
Feb 8, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
Show resolved
Hide resolved
Signed-off-by: Zike Yang <[email protected]>
Signed-off-by: Zike Yang <[email protected]>
| @PathParam("namespace") String namespace, @PathParam("topic") @Encoded String encodedTopic, | ||
| @QueryParam("force") @DefaultValue("false") boolean force, | ||
| @QueryParam("authoritative") @DefaultValue("false") boolean authoritative, | ||
| @QueryParam("deleteSchema") @DefaultValue("false") boolean deleteSchema) { | ||
| validateTopicName(property, cluster, namespace, encodedTopic); |
There was a problem hiding this comment.
Same as #14064 (comment)
|
The pr had no activity for 30 days, mark with Stale label. |
19 tasks
|
The pr had no activity for 30 days, mark with Stale label. |
|
These changes have been moved to #16232. So close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #14013
Motivation
See #14013
Modifications
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
no-need-doc