Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Broker] Make PersistentTopicsBase#internalUpdatePartitionedTopic async #14141

Merged
merged 11 commits into from
Apr 30, 2022

Conversation

Technoboy-
Copy link
Contributor

Motivation

Make PersistentTopicsBase#internalUpdatePartitionedTopic async.

Documentation

  • no-need-doc

@Technoboy- Technoboy- self-assigned this Feb 7, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 7, 2022
Copy link
Member

@mattisonchao mattisonchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments here. PTAL :)

@mattisonchao
Copy link
Member

mattisonchao commented Feb 7, 2022

@Technoboy- Please add tag component/management.

Thanks~

@Technoboy- Technoboy- changed the title Make PersistentTopicsBase#internalUpdatePartitionedTopic async [Broker] Make PersistentTopicsBase#internalUpdatePartitionedTopic async Feb 7, 2022
@Technoboy-
Copy link
Contributor Author

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added this to the 2.10.0 milestone Feb 8, 2022
@codelipenghui codelipenghui modified the milestones: 2.10.0, 2.11.0 Feb 8, 2022
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@Technoboy- Technoboy- added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker labels Apr 29, 2022
Copy link
Contributor

@gaoran10 gaoran10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Technoboy- Technoboy- merged commit 003182b into apache:master Apr 30, 2022
@Technoboy- Technoboy- deleted the updatePartitionedTopic-async branch August 10, 2022 05:50
gaozhangmin pushed a commit to gaozhangmin/pulsar that referenced this pull request Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants