Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Broker] Fix NPE of internalExpireMessagesByTimestamp #14243

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

nodece
Copy link
Member

@nodece nodece commented Feb 11, 2022

Motivation

This issue was triggered by #13880, it doesn't handle the NPE in here, we can check the diff code in #13880.

/cc @liudezhi2098

Modifications

  • Use if instead of checkNotNull

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • no-need-doc - Fix the code

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 11, 2022
@codelipenghui codelipenghui added this to the 2.10.0 milestone Feb 14, 2022
@codelipenghui codelipenghui merged commit a3c8525 into apache:master Feb 14, 2022
@lhotari
Copy link
Member

lhotari commented Feb 14, 2022

@codelipenghui @merlimat @Technoboy- @mattisonchao Why are the sync -> async changes made just before 2.10.0 release? This introduces new bugs as we can see once again. This bug fix is needed since #13880 introduced a new bug.
This is not the only case. I hope that this gets followed up on the dev mailing list asap.
#14013 (comment)
#14163 (comment)

BewareMyPower added a commit that referenced this pull request Aug 1, 2022
Migrate the `setupDefaultTenantAndNamespace` method from
#14243.
@congbobo184 congbobo184 added cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life labels Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.9.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants