[improve][doc] Document configuration added by PIP-145 #16936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc
Anonymitaet
requested changes
Aug 4, 2022
momo-jun
approved these changes
Aug 5, 2022
Anonymitaet
reviewed
Aug 15, 2022
There was a problem hiding this comment.
@freeznet
could you please review this PR from the technical perspective? Thank you!
freeznet
approved these changes
Aug 15, 2022
Co-authored-by: Anonymitaet <[email protected]>
Anonymitaet
approved these changes
Aug 22, 2022
|
/pulsarbot rerun-failure-checks |
1 similar comment
|
/pulsarbot rerun-failure-checks |
|
/pulsarbot run-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #14505
Motivation
Documentation for the new configuration properties was missing when the feature was merged.
Modifications
Added the new configuration properties to standalone.conf and broker.conf. Also, added documentation to site2/docs/reference-configuration.md .
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
doc