Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][broker] Unregister topic policy listener if managed ledger close failed #17652

Merged
merged 1 commit into from
Sep 15, 2022
Merged

[fix][broker] Unregister topic policy listener if managed ledger close failed #17652

merged 1 commit into from
Sep 15, 2022

Conversation

codelipenghui
Copy link
Contributor

Motivation

After the topic closed failed due to metadata BadVersionException, we should unregister the topic policy listener.
Otherwise, the topic policy listener will get leaked.

image

@codelipenghui codelipenghui self-assigned this Sep 14, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Sep 14, 2022
@github-actions
Copy link

@codelipenghui Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@codelipenghui codelipenghui added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Sep 15, 2022
@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Sep 15, 2022
@codelipenghui codelipenghui added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Sep 15, 2022
@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Sep 15, 2022
@Technoboy- Technoboy- added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Sep 15, 2022
@github-actions github-actions bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Sep 15, 2022
mattisonchao
mattisonchao approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@mattisonchao mattisonchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@Technoboy- Technoboy- merged commit dc54997 into apache:master Sep 15, 2022
@Technoboy- Technoboy- modified the milestones: 2.12.0, 2.11.0 Sep 15, 2022
Technoboy- pushed a commit that referenced this pull request Sep 15, 2022
@codelipenghui @Technoboy-
[fix][broker] Unregister topic policy listener if managed ledger clos…
91fbfda 
…e failed (#17652)
@codelipenghui codelipenghui deleted the penghui/unregister_topic_policy_listener branch September 15, 2022 03:33
@Jason918
Copy link
Contributor

Covered by #17736 in branch-2.10

congbobo184 pushed a commit that referenced this pull request Nov 9, 2022
@codelipenghui
[fix][broker] Unregister topic policy listener if managed ledger clos…
98c1629 
…e failed (#17652)

(cherry picked from commit dc54997)
@congbobo184 congbobo184 added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Nov 9, 2022
congbobo184 pushed a commit that referenced this pull request Nov 26, 2022
@codelipenghui
[fix][broker] Unregister topic policy listener if managed ledger clos…
668f6d4 
…e failed (#17652)

(cherry picked from commit dc54997)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattisonchao mattisonchao mattisonchao approved these changes

@Technoboy- Technoboy- Technoboy- approved these changes

Assignees

@codelipenghui codelipenghui

Labels
area/broker cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 cherry-picked/branch-2.11 doc-label-missing release/2.9.4 release/2.10.2 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@codelipenghui @Jason918 @Technoboy- @mattisonchao @congbobo184