[fix][flaky-test]PerformanceTransactionTest.testConsumeTxnMessage #17837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@poorbarcode Please provide a correct documentation label for your PR. |
poorbarcode
force-pushed
the
flaky/testConsumeTxnMessage
branch
from
6027e10 to
3e7d1d9
Compare
poorbarcode
force-pushed
the
flaky/testConsumeTxnMessage
branch
from
3e7d1d9 to
7b934dc
Compare
github-actions
bot
added
doc-not-needed
congbobo184
requested review from
liangyepianzhou,
congbobo184,
codelipenghui and
gaoran10
congbobo184
approved these changes
Sep 27, 2022
liangyepianzhou
approved these changes
Sep 27, 2022
codelipenghui
approved these changes
Sep 27, 2022
|
Can this PR merge? (^_^) |
5 tasks
congbobo184
pushed a commit
that referenced
this pull request
Nov 3, 2022
<!-- ### Contribution Checklist - PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. --> <!-- Either this PR fixes an issue, --> Fixes #18282 ### Modifications We start 10 transactions and consume 50 messages in every transaction by default. But notice `-r 10` set the consumption rate limit to be 10 msg per second, so every transaction is about 5 seconds. In #17837 we set the transaction TTL to be 5 seconds, so transactions may be timeout randomly, which causes the test to fail. To prove this, you can try to set `-r 9` or `-tto 4`, which will cause failure 100%. So remove the `-r` option can fix this issue. ### Verifying this change - [x] Make sure that the change passes the CI checks. ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: labuladong#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14109
Motivation
The expected execution flow for this test is:
(High light) The default value for transaction TTL is 10 seconds, and the default value for
Awaitility.awaitis also 10 seconds, so this test is not stable.Note: This is a guess cause, the problem is not reproduced locally. But after transaction TTL is set to 11s, the probability of the problem occurring is 100%.
Modifications
Fix flaky test
Other changes
Documentation
doc-requireddoc-not-neededdocdoc-completeMatching PR in forked repository
PR in forked repository: