Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-run][fix][flaky-test]PerformanceTransactionTest.testConsumeTxnMessage #13

Closed
wants to merge 17 commits into from

Conversation

poorbarcode
Copy link
Owner

@poorbarcode poorbarcode commented Sep 26, 2022

tisonkun and others added 16 commits September 23, 2022 15:19
…pache#17798)

* docs: Trino -> PrestoSQL

Signed-off-by: tison <[email protected]>

* Trino -> PrestoSQL for sql-rest-api

Signed-off-by: tison <[email protected]>

* Trino -> PrestoSQL for sql-deployment-configurations

Signed-off-by: tison <[email protected]>

* Trino -> PrestoSQL for sql-getting-started

Signed-off-by: tison <[email protected]>

* add caveat

Signed-off-by: tison <[email protected]>

Signed-off-by: tison <[email protected]>
We no longer sync this folder and it's reasonable to keep the truth on the pulsar-site repo.

This refers to apache#17817.
This enables GitHub hyperlinks in IDEA for commits containing PR information
* Make BookieId work with PulsarRegistrationDriver

* Switch to MetadataCache

* checkstyle
* add missing files for 2.1.1-incubating

* add missing files for 2.2.0 and 2.2.1

* add missing files for 2.3.0, 2.3.1 and 2.3.2

* add missing files for 2.4.0, 2.4.1, and 2.4.2

* add missing files for 2.5.1 and 2.5.2

* preview fix
@poorbarcode poorbarcode changed the title Flaky/test consume txn message [ci-run][fix][flaky-test]PerformanceTransactionTest.testConsumeTxnMessage Sep 26, 2022
@poorbarcode poorbarcode force-pushed the flaky/testConsumeTxnMessage branch from 6027e10 to 3e7d1d9 Compare September 26, 2022 16:50
@poorbarcode poorbarcode force-pushed the flaky/testConsumeTxnMessage branch from 3e7d1d9 to 7b934dc Compare September 26, 2022 17:14
congbobo184 pushed a commit to apache/pulsar that referenced this pull request Sep 29, 2022
…7837)

Fixes: #14109


### Motivation

The expected execution flow for this test is: 

1. send 505 messages
2. commit 10 transactions, every transaction ack 50 messages
3. receive the last 5 messages in the last transaction, wait for transaction timeout
4. confirm that the last 5 messages can be consumed by new consumer

<strong>(High light)</strong> The default value for transaction TTL is 10 seconds, and the default value for `Awaitility.await` is also 10 seconds,  so this test is not stable.

Note: This is a guess cause, the problem is not reproduced locally. But after transaction TTL is set to 11s, the probability of the problem occurring is 100%.

### Modifications

Fix flaky test
- set transaction TTL to 5s

Other changes
- define a name for the task thread
- acknowledge the last 5 messages

### Matching PR in forked repository

PR in forked repository: 

- poorbarcode#13
@poorbarcode poorbarcode deleted the flaky/testConsumeTxnMessage branch September 29, 2022 12:32
poorbarcode pushed a commit that referenced this pull request Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants