Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIP-25: Token based authentication #2888
PIP-25: Token based authentication #2888
Changes from 7 commits
0a519d6
77011c0
43ab2a7
3f01509
01d55a3
a46916e
0760e68
6f9b1a1
a479e8e
2fed618
5908407
7f31a70
0004810
a2dc91f
811643a
5deae68
a30efb7
a6856db
2cddaa8
34b70be
ae8a52d
703d5ca
3744510
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be valid for a super simple case, but it wouldn’t work for cases that has mime-type or base64 encoding.
Why didn’t you use the URL class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... because I've never used
URL.openStream()
before :)Though, one thing is that the key is expected to be already base64 encoded.
Then one would just have to store the key string somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m ok with parsing the schemes here and having a limitation in its format for now, but I still think this data scheme parsing is incorrect. It always need a comma after the colon.
https://tools.ietf.org/html/rfc2397#section-3
Also, base64 encoding is not mandatory. You can pass URL encoded string instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maskit I have updated to conform with
data:
standard url, though I had to add manual parsing since javaURL
class doesn't support it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you look into #1212 I commented on another line? The URL class I suggested is
org.apache.pulsar.client.api.url.URL
. The parser already exists in it.