Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIP-25: Token based authentication #2888

Merged
merged 23 commits into from
Nov 28, 2018
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bin/pulsar
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ where command is one of:
initialize-cluster-metadata One-time metadata initialization
compact-topic Run compaction against a topic
zookeeper-shell Open a ZK shell client
tokens Utility to create authentication tokens

help This help message

Expand Down Expand Up @@ -325,6 +326,8 @@ elif [ $COMMAND == "sql" ]; then
exec $JAVA -cp "${PRESTO_HOME}/lib/*" com.facebook.presto.cli.Presto --server localhost:8081 "${@}"
elif [ $COMMAND == "sql-worker" ]; then
exec ${PRESTO_HOME}/bin/launcher --etc-dir ${PULSAR_PRESTO_CONF} "${@}"
elif [ $COMMAND == "tokens" ]; then
exec $JAVA $OPTS org.apache.pulsar.utils.auth.tokens.TokensCliUtils $@
elif [ $COMMAND == "help" ]; then
pulsar_help;
else
Expand Down
18 changes: 18 additions & 0 deletions conf/broker.conf
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,24 @@ athenzDomainNames=
# When this parameter is not empty, unauthenticated users perform as anonymousUserRole
anonymousUserRole=

### --- Token Authentication Provider --- ###
merlimat marked this conversation as resolved.
Show resolved Hide resolved

## Simmetric key
merlimat marked this conversation as resolved.
Show resolved Hide resolved
# Configure the secret key to be used to validate auth tokens
# The key can be specified like:
# tokenSecretKey=data:xxxxxxxxx
# tokenSecretKey=file:///my/secret.key
# tokenSecretKey=env:MY_SECRET_KEY_VAR
tokenSecretKey=

## Asymmetric public/private key pair
# Configure the public key to be used to validate auth tokens
# The key can be specified like:
# tokenPublicKey=data:xxxxxxxxx
# tokenPublicKey=file:///my/public.key
# tokenPublicKey=env:MY_PUBLIC_KEY_VAR
tokenPublicKey=

### --- BookKeeper Client --- ###

# Authentication plugin to use when connecting to bookies
Expand Down
4 changes: 4 additions & 0 deletions distribution/server/src/assemble/LICENSE.bin.txt
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,10 @@ The Apache Software License, Version 2.0
- io.dropwizard.metrics-metrics-jvm-3.1.0.jar
* Prometheus
- io.prometheus-simpleclient_httpserver-0.5.0.jar
* Java JSON WebTokens
- io.jsonwebtoken-jjwt-api-0.10.5.jar
- io.jsonwebtoken-jjwt-impl-0.10.5.jar
- io.jsonwebtoken-jjwt-jackson-0.10.5.jar


BSD 3-clause "New" or "Revised" License
Expand Down
17 changes: 17 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ flexible messaging model and an intuitive client API.</description>
<flink.version>1.6.0</flink.version>
<scala.binary.version>2.11</scala.binary.version>
<debezium.version>0.8.2</debezium.version>
<jsonwebtoken.version>0.10.5</jsonwebtoken.version>

<!-- test dependencies -->
<arquillian-cube.version>1.15.1</arquillian-cube.version>
Expand Down Expand Up @@ -728,6 +729,22 @@ flexible messaging model and an intuitive client API.</description>
</exclusion>
</exclusions>
</dependency>

<dependency>
<groupId>io.jsonwebtoken</groupId>
merlimat marked this conversation as resolved.
Show resolved Hide resolved
<artifactId>jjwt-api</artifactId>
<version>${jsonwebtoken.version}</version>
</dependency>
<dependency>
<groupId>io.jsonwebtoken</groupId>
<artifactId>jjwt-impl</artifactId>
<version>${jsonwebtoken.version}</version>
</dependency>
<dependency>
<groupId>io.jsonwebtoken</groupId>
<artifactId>jjwt-jackson</artifactId>
<version>${jsonwebtoken.version}</version>
</dependency>

<dependency>
<groupId>org.aspectj</groupId>
Expand Down
9 changes: 9 additions & 0 deletions pulsar-broker-common/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,14 @@
<artifactId>javax.ws.rs-api</artifactId>
</dependency>

<dependency>
<groupId>io.jsonwebtoken</groupId>
<artifactId>jjwt-impl</artifactId>
</dependency>

<dependency>
<groupId>io.jsonwebtoken</groupId>
<artifactId>jjwt-jackson</artifactId>
</dependency>
</dependencies>
</project>
Original file line number Diff line number Diff line change
@@ -0,0 +1,147 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.pulsar.broker.authentication;

import com.google.common.base.Charsets;

import io.jsonwebtoken.Claims;
import io.jsonwebtoken.Jwt;
import io.jsonwebtoken.JwtException;
import io.jsonwebtoken.Jwts;

import java.io.IOException;
import java.net.URI;
import java.nio.file.Files;
import java.nio.file.Paths;
import java.security.Key;

import javax.naming.AuthenticationException;

import lombok.extern.slf4j.Slf4j;

import org.apache.pulsar.broker.ServiceConfiguration;
import org.apache.pulsar.broker.authentication.utils.AuthTokenUtils;

@Slf4j
public class AuthenticationProviderToken implements AuthenticationProvider {

public final static String HTTP_HEADER_NAME = "Authorization";
final static String HTTP_HEADER_VALUE_PREFIX = "Bearer ";

// When simmetric key is configured
final static String CONF_TOKEN_SECRET_KEY = "tokenSecretKey";
merlimat marked this conversation as resolved.
Show resolved Hide resolved

// When public/private key pair is configured
final static String CONF_TOKEN_PUBLIC_KEY = "tokenPublicKey";

private Key validationKey;

@Override
public void close() throws IOException {
// noop
}

@Override
public void initialize(ServiceConfiguration config) throws IOException {
this.validationKey = getValidationKey(config);
}

@Override
public String getAuthMethodName() {
return "token";
}

@Override
public String authenticate(AuthenticationDataSource authData) throws AuthenticationException {
String token = null;

if (authData.hasDataFromCommand()) {
// Authenticate Pulsar binary connection
token = authData.getCommandData();
} else if (authData.hasDataFromHttp()) {
// Authentication HTTP request. The format here should be compliant to RFC-6750
// (https://tools.ietf.org/html/rfc6750#section-2.1). Eg:
//
// Authorization: Bearer xxxxxxxxxxxxx
String httpHeaderValue = authData.getHttpHeader(HTTP_HEADER_NAME);
if (!httpHeaderValue.startsWith(HTTP_HEADER_VALUE_PREFIX)) {
throw new AuthenticationException("Invalid HTTP Authorization header");
}

// Remove prefix
token = httpHeaderValue.substring(HTTP_HEADER_VALUE_PREFIX.length());
} else {
throw new AuthenticationException("No token credentials passed");
}

// Validate the token
try {
@SuppressWarnings("unchecked")
Jwt<?, Claims> jwt = Jwts.parser()
.setSigningKey(validationKey)
.parse(token);

return jwt.getBody().getSubject();
} catch (JwtException e) {
throw new AuthenticationException("Failed to authentication token: " + e.getMessage());
}
}

/**
* Try to get the validation key for tokens from several possible config options.
*/
private static Key getValidationKey(ServiceConfiguration conf) throws IOException {
final boolean isPublicKey;
final String validationKeyConfig;

if (conf.getProperty(CONF_TOKEN_SECRET_KEY) != null) {
isPublicKey = false;
validationKeyConfig = (String) conf.getProperty(CONF_TOKEN_SECRET_KEY);
} else if (conf.getProperty(CONF_TOKEN_PUBLIC_KEY) != null) {
isPublicKey = true;
validationKeyConfig = (String) conf.getProperty(CONF_TOKEN_PUBLIC_KEY);
} else {
throw new IOException("No secret key was provided for token authentication");
}

final String validationKey;

if (validationKeyConfig.startsWith("data:")) {
log.info("Reading token validation key from config file");
validationKey = validationKeyConfig.substring("data:".length());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be valid for a super simple case, but it wouldn’t work for cases that has mime-type or base64 encoding.

Why didn’t you use the URL class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... because I've never used URL.openStream() before :)

Though, one thing is that the key is expected to be already base64 encoded.

$ bin/pulsar tokens create-secret-key
secret-key CBqtuReZe+8nKqtJBbmuPTIg6b4W1KjOS21pcJkTJ/8=

Then one would just have to store the key string somewhere.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m ok with parsing the schemes here and having a limitation in its format for now, but I still think this data scheme parsing is incorrect. It always need a comma after the colon.
https://tools.ietf.org/html/rfc2397#section-3

Also, base64 encoding is not mandatory. You can pass URL encoded string instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maskit I have updated to conform with data: standard url, though I had to add manual parsing since java URL class doesn't support it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you look into #1212 I commented on another line? The URL class I suggested is org.apache.pulsar.client.api.url.URL. The parser already exists in it.

} else if (validationKeyConfig.startsWith("env:")) {
String envVarName = validationKeyConfig.substring("env:".length());
log.info("Reading token validation key from env variable '{}'", envVarName);
validationKey = System.getenv(envVarName);
} else if (validationKeyConfig.startsWith("file:")) {
URI filePath = URI.create(validationKeyConfig);
log.info("Reading secret key from file '{}'", filePath);
validationKey = new String(Files.readAllBytes(Paths.get(filePath)), Charsets.UTF_8);
} else {
// Assume the key content was passed
validationKey = validationKeyConfig;
}

if (isPublicKey) {
return AuthTokenUtils.decodePublicKey(validationKey);
} else {
return AuthTokenUtils.decodeSecretKey(validationKey);
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.pulsar.broker.authentication.utils;

import io.jsonwebtoken.JwtBuilder;
import io.jsonwebtoken.Jwts;
import io.jsonwebtoken.SignatureAlgorithm;
import io.jsonwebtoken.io.Decoders;
import io.jsonwebtoken.io.Encoders;
import io.jsonwebtoken.security.Keys;

import java.io.IOException;
import java.security.Key;
import java.security.KeyFactory;
import java.security.PrivateKey;
import java.security.PublicKey;
import java.security.spec.PKCS8EncodedKeySpec;
import java.security.spec.X509EncodedKeySpec;
import java.util.Date;
import java.util.Optional;

import javax.crypto.SecretKey;

import lombok.experimental.UtilityClass;

@UtilityClass
public class AuthTokenUtils {

public static String createSecretKey(SignatureAlgorithm signatureAlgorithm) {
Key key = Keys.secretKeyFor(signatureAlgorithm);
return Encoders.BASE64.encode(key.getEncoded());
}

public static SecretKey decodeSecretKey(String secretKey) {
return Keys.hmacShaKeyFor(Decoders.BASE64.decode(secretKey));
}

public static PrivateKey decodePrivateKey(String key) throws IOException {
try {
PKCS8EncodedKeySpec spec = new PKCS8EncodedKeySpec(Decoders.BASE64.decode(key));
KeyFactory kf = KeyFactory.getInstance("RSA");
return kf.generatePrivate(spec);
} catch (Exception e) {
throw new IOException("Failed to decode private key", e);
}
}

public static PublicKey decodePublicKey(String key) throws IOException {
try {
X509EncodedKeySpec spec = new X509EncodedKeySpec(Decoders.BASE64.decode(key));
KeyFactory kf = KeyFactory.getInstance("RSA");
return kf.generatePublic(spec);
} catch (Exception e) {
throw new IOException("Failed to decode public key", e);
}
}

public static String encodeKey(Key key) {
return Encoders.BASE64.encode(key.getEncoded());
}

public static String createToken(Key signingKey, String subject, Optional<Date> expiryTime) {
JwtBuilder builder = Jwts.builder()
.setSubject(subject)
.signWith(signingKey);

if (expiryTime.isPresent()) {
builder.setExpiration(expiryTime.get());
}

return builder.compact();
}
}
Loading