-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Although defined, some elements are not translated #25988
Comments
I use Supserset in version 3.0.0 |
I've found that the menu items are populated from the backend, not the front-end. So the translated values must be in the Hope that helps! |
@xavier-GitHub76 |
This is related to the issue #26738 |
I'm not sure how we ought to handle this, really, but I suspect it's quietly affecting a lot of people that just don't realize it. Should we auto-generate the .mo files again? I'm not sure the advantage/history of why those are currently not included... just file size? I think @mistercrunch knows the history on their removal, but I'm not sure anyone's feelings for or against reintroducing them. Also curious if people think we should leave this open (since it's kind of a bug) or close this out in favor of the open Discussion. |
I'm thinking we should add the .mo and .json file build as part of the docker and pypi builds, and keep these files out of the repo. |
I wonder if we could even generate them at start time, since (as I recall) they're pretty slow. If we do that, then it's not a breaking change, the repo gets lighter, and the translations will be up to date every time the code changes. |
at 10-20 seconds each (pybabel and po2json) I think it's a bit slow to force that on web-server start, plus there are many ways to start the web server, and many people don't care for all or some of the translations... I think this fits perfectly in a docker build and/or pypi build steps, though it does add a bit of weights to the images/bundles (about 8mb) which I think is totally fine |
True... though |
Wait but the built frontend assets are bundled in the python package, meaning if you get the package you don't need to have node/npm, run npm i, npm run build, ... Should be prepackaged. I guess similarly here we can compile and package .po+.json, and people don't have to have all that extra junk (npm / po2json / pybabel / ...). Also doesn't seem good practice (is it even allowed) to mutate the package in place post install. I think you'd be supposed to do this in home somewhere like ~/.superset/ ... |
Right, the npm/webpack built assets are indeed included in the python package... which I thought was done via |
My proposal to improve things around translations -> #28483 |
Hello,
I had created an issue (#21493) but it has multiples cause of no translation.
I specialise this issue on elements not translated although defined
It's not just a lack of traduction
Items are :
Screenshot :
The french translation are not applied.
Best regard
The text was updated successfully, but these errors were encountered: