-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correction translation #28434
fix: Correction translation #28434
Conversation
Correction translation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #28434 +/- ##
==========================================
+ Coverage 60.48% 67.27% +6.79%
==========================================
Files 1931 1944 +13
Lines 76236 77305 +1069
Branches 8568 8671 +103
==========================================
+ Hits 46114 52010 +5896
+ Misses 28017 23171 -4846
- Partials 2105 2124 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Assuming we would:
I guess that leaves people building from the repo directly out From the perspective of pypi/docker it's not a breaking change. For the rest, maybe a note in |
For others' context, there's a somewhat parallel discussion happening here: I think it's fair to remove the .mo/.json files if the're auto-generated at a time that supports as many use cases as possible. I'm not sure if dockery/pypi cover all the bases one would expect. If this were to be done at start time, I think it's pretty quick, but it might be possible to even do it conditionally depending on configuration... then those who have translations enabled always run the freshest translations, no matter how they install/run Superset. |
…che#28309) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rusackas It will impact what I did ? |
@aehanno I think your PR is OK... we're just trying to figure out what to do with the json files, and it's just kind of happening on this thread randomly. |
Actually @aehanno, in looking at the PR files, there are a whole lot of changed files that look like they have nothing to do with translations. Maybe the rebase didn't work right? |
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
…che#28309) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
I did another merge and rebase but I still got those change The diff is weird beacause if we check the first file for example, that say I change the version from 4.0.0 to 4.0.1 but I checked the same file in master branch and I got 4.0.1 |
Yeah, something here isn't right. I suspect you're merging |
Correction translation
change from po2json.sh
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
… add-new-translation-french
@rusackas Can be a solution to create a new branch then the pull request ? Instead of did the correction on this one |
@aehanno absolutely. I've definitely done it several times :D |
New PR here #28497 |
Correction french translation
SUMMARY
Remove to fuzzy to add the right translation
BEFORE
TESTING INSTRUCTIONS
Check that after we got the new translation