chore: Remove unused CodeModal #11972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11972 +/- ##
==========================================
+ Coverage 63.75% 64.11% +0.36%
==========================================
Files 941 476 -465
Lines 45654 29386 -16268
Branches 4389 0 -4389
==========================================
- Hits 29106 18842 -10264
+ Misses 16371 10544 -5827
+ Partials 177 0 -177
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@etr2460 🙏 |
etr2460
reviewed
Dec 15, 2020
| codeCallback: PropTypes.func, | ||
| type CodeModalProps = { | ||
| triggerNode: JSX.Element; | ||
| code?: string; |
There was a problem hiding this comment.
as mentioned here: i think this can be required now: https://github.com/apache/incubator-superset/pull/11971/files#r540334777
| type CodeModalProps = { | ||
| triggerNode: JSX.Element; | ||
| code?: string; | ||
| codeCallback: () => string; |
There was a problem hiding this comment.
this doesn't seem to match the type of the default codeCallback prop
|
@etr2460 Seems that this CodeModal is not used anywhere, maybe we can remove it? |
|
Hmm, yeah i don't see it used anywhere. Might as well delete it then! |
etr2460
changed the title
etr2460
approved these changes
Dec 16, 2020
amitmiran137
pushed a commit
to simcha90/incubator-superset
that referenced
this pull request
Dec 18, 2020
* upstream/master: (55 commits) feat(explore): time picker enhancement (apache#11418) feat: update alert/report icons and column order (apache#12081) feat(explore): metrics and filters controls redesign (apache#12095) feat(alerts/reports): add refresh action (apache#12071) chore: add latest tag action (apache#11148) fix(reports): increase crontab size and alert fixes (apache#12056) Small typo fix in Athena connection docs (apache#12099) feat(queries): security perm simplification (apache#12072) feat(databases): security perm simplification (apache#12036) feat(dashboards): security permissions simplification (apache#12012) feat(logs): security permissions simplification (apache#12061) chore: Remove unused CodeModal (apache#11972) Fix typescript error (apache#12074) fix: handle context-dependent feature flags in CLI (apache#12088) fix: Fix "View in SQLLab" bug (apache#12086) feat(alert/report): add 'not null' condition option to modal (apache#12077) bumping superset ui to 15.18 and deckgl to 0.3.2 (apache#12078) fix: Python dependencies in apache#11499 (apache#12079) reset active tab on open (apache#12048) fix: improve import flow UI/UX (apache#12070) ...
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file was unused throughout the codebase, so removing it (and the test)