Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump npm to version 7 #16748

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Conversation

villebro
Copy link
Member

@villebro villebro commented Sep 20, 2021

While the docs state npm@7 to be a requirement for running Superset (see #13100 which migrated to then new lockfile format), CI is still running version 6. It turns out running npm@7 with node@14 isn't very well supported: actions/setup-node#213 . Long term, we should probably bump to node@16 to get rid of this workaround.

When running npm ci on #16701 using npm@6 we get the following error:

$ npm i -g npm@6
$ npm --version
6.14.15
$ npm ci

npm WARN prepare removing existing node_modules/ before installation
npm ERR! watchpack-chokidar2 not accessible from watchpack

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/ville/.npm/_logs/2021-09-20T11_10_20_593Z-debug.log

This is fixed by simply bumping to version 7:

$ npm i -g npm@7
$ npm ci
...
added 3599 packages, and audited 3600 packages in 3m

248 packages are looking for funding
  run `npm fund` for details

79 vulnerabilities (11 low, 22 moderate, 46 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

After this update, CI uses npm@7:
image

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro force-pushed the villebro/ci-npm7 branch 2 times, most recently from 230e1e4 to 52f9afd Compare September 20, 2021 11:22
@@ -37,7 +37,7 @@ do
REGEX="(^\.github\/workflows\/.*python|^tests\/|^superset\/|^setup\.py|^requirements\/.+\.txt|^\.pylintrc)"
echo "Searching for changes in python files"
elif [[ ${CHECK} == "frontend" ]]; then
REGEX="(^\.github\/workflows\/.*(frontend|e2e)|^superset-frontend\/)"
REGEX="(^\.github\/workflows\/.*(bashlib|frontend|e2e)|^superset-frontend\/)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding changes in bashlib.sh to flag frontend changes, as this file controls many aspects of how dependencies are managed on CI.

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #16748 (a4f7bda) into master (985aa06) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16748   +/-   ##
=======================================
  Coverage   76.86%   76.86%           
=======================================
  Files        1007     1007           
  Lines       54174    54174           
  Branches     7463     7463           
=======================================
  Hits        41639    41639           
  Misses      12295    12295           
  Partials      240      240           
Flag Coverage Δ
javascript 71.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 985aa06...a4f7bda. Read the comment docs.

@villebro villebro merged commit b92358b into apache:master Sep 20, 2021
@villebro villebro mentioned this pull request Sep 23, 2021
9 tasks
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants