Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correction translation #28497

Merged
merged 2 commits into from
May 17, 2024

Conversation

aehanno
Copy link
Contributor

@aehanno aehanno commented May 14, 2024

Correction french translation

SUMMARY

Remove to fuzzy to add the right translation

BEFORE

image

TESTING INSTRUCTIONS

Check that after we got the new translation

change from po2json.sh
@aehanno aehanno requested review from villebro and rusackas as code owners May 14, 2024 17:46
@aehanno aehanno changed the title Correction translation fix: Correction translation May 14, 2024
@github-actions github-actions bot added i18n Namespace | Anything related to localization i18n:spanish Translation related to Spanish language i18n:italian Translation related to Italian language i18n:french Translation related to French language i18n:chinese Translation related to Chinese language i18n:japanese Translation related to Japanese language i18n:russian Translation related to Russian language i18n:korean Translation related to Korean language i18n:dutch i18n:slovak i18n:ukrainian i18n:portuguese i18n:brazilian i18n:traditional-chinese labels May 14, 2024
@dosubot dosubot bot added i18n:brazillian Translation related to Brazilian i18n:slovenian labels May 14, 2024
@aehanno
Copy link
Contributor Author

aehanno commented May 14, 2024

@rusackas There is my new PR
I don't know if we waiting the end of the discussion about the .json file before merging mine ?

@aehanno
Copy link
Contributor Author

aehanno commented May 17, 2024

@rusackas and @villebro, can we go forward with this PR ?

@github-actions github-actions bot removed the i18n:japanese Translation related to Japanese language label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.48%. Comparing base (76d897e) to head (1ae06fa).
Report is 1094 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #28497       +/-   ##
===========================================
+ Coverage   60.48%   83.48%   +22.99%     
===========================================
  Files        1931      521     -1410     
  Lines       76236    37483    -38753     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31293    -14821     
+ Misses      28017     6190    -21827     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.09% <ø> (-0.08%) ⬇️
javascript ?
mysql 77.14% <ø> (?)
postgres 77.28% <ø> (?)
presto 53.64% <ø> (-0.16%) ⬇️
python 83.48% <ø> (+19.99%) ⬆️
sqlite 76.73% <ø> (?)
unit 58.94% <ø> (+1.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas merged commit a2947d0 into apache:master May 17, 2024
34 checks passed
@rusackas
Copy link
Member

Done! Thanks for the fix!

EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@aehanno
Copy link
Contributor Author

aehanno commented Jul 17, 2024

Hi @rusackas, I see the tag 4.0.2 has been release but without this PR
How I can put it in the next one ?

@rusackas
Copy link
Member

@michael-s-molina would have the most context on the patch releases, but I can say that 4.1 (coming soon, pending timeline from @sadpandajoe) should include this, since it'll be a fresh cut from the master branch.

vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels i18n:brazilian i18n:brazillian Translation related to Brazilian i18n:chinese Translation related to Chinese language i18n:dutch i18n:french Translation related to French language i18n:italian Translation related to Italian language i18n:korean Translation related to Korean language i18n:portuguese i18n:russian Translation related to Russian language i18n:slovak i18n:slovenian i18n:spanish Translation related to Spanish language i18n:traditional-chinese i18n:ukrainian i18n Namespace | Anything related to localization size/XXL 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants