Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix: re-enable cypress checks" #32045

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

mistercrunch
Copy link
Member

Reverts #32008

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Fix Detected
Functionality Parallel Test Synchronization Issue ▹ view
Files scanned
File Path Reviewed
scripts/cypress_run.py

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Naming
Database Operations
Documentation
Logging
Error Handling
Systems and Environment
Objects and Data Structures
Readability and Maintainability
Asynchronous Processing
Design Patterns
Third-Party Libraries
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

Comment on lines 60 to 63
f"--browser {browser} "
f"--record --group {group_id} --tag {REPO},{GITHUB_EVENT_NAME} "
f"--ci-build-id {build_id} "
f"--wait-for-missing-groups "
f"-- {chrome_flags}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parallel Test Synchronization Issue category Functionality

Tell me more
What is the issue?

Removing the '--wait-for-missing-groups' flag in parallel Cypress test execution could lead to test runs completing before all parallel groups are ready, potentially missing test failures in other groups.

Why this matters

In a CI environment with parallel test execution, not waiting for all groups can result in false positives where the build is marked as successful even if other parallel groups later fail.

Suggested change ∙ Feature Preview

Retain the '--wait-for-missing-groups' flag to ensure proper synchronization between parallel test groups:

f"--browser {browser} "
f"--record --group {group_id} --tag {REPO},{GITHUB_EVENT_NAME} "
f"--ci-build-id {build_id} "
f"--wait-for-missing-groups "
f"-- {chrome_flags}"

Report a problem with this comment

💬 Chat with Korbit by mentioning @korbit-ai.

@michael-s-molina michael-s-molina changed the title Revert "fix: re-enable cypress checks" fix: Revert "fix: re-enable cypress checks" Jan 30, 2025
Copy link
Member

@sadpandajoe sadpandajoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit 568f6d9 into master Jan 30, 2025
52 of 55 checks passed
@michael-s-molina michael-s-molina deleted the revert-32008-reenable-cypress-checks branch January 30, 2025 17:20
tmsjordan pushed a commit to tmsdevelopment/superset that referenced this pull request Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants