Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix: re-enable cypress checks" #32045

Merged
merged 1 commit into from
Jan 30, 2025
Merged

fix: Revert "fix: re-enable cypress checks" #32045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
*.swp
__pycache__

.aider.*
.local
.cache
.bento*
Expand Down
1 change: 0 additions & 1 deletion scripts/cypress_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ def run_cypress_for_test_file(
f"--browser {browser} "
f"--record --group {group_id} --tag {REPO},{GITHUB_EVENT_NAME} "
f"--ci-build-id {build_id} "
f"--wait-for-missing-groups "
f"-- {chrome_flags}"
Comment on lines 60 to 63
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parallel Test Synchronization Issue category Functionality

Tell me more
What is the issue?

Removing the '--wait-for-missing-groups' flag in parallel Cypress test execution could lead to test runs completing before all parallel groups are ready, potentially missing test failures in other groups.

Why this matters

In a CI environment with parallel test execution, not waiting for all groups can result in false positives where the build is marked as successful even if other parallel groups later fail.

Suggested change ∙ Feature Preview

Retain the '--wait-for-missing-groups' flag to ensure proper synchronization between parallel test groups:

f"--browser {browser} "
f"--record --group {group_id} --tag {REPO},{GITHUB_EVENT_NAME} "
f"--ci-build-id {build_id} "
f"--wait-for-missing-groups "
f"-- {chrome_flags}"

Report a problem with this comment

💬 Chat with Korbit by mentioning @korbit-ai.

)
else:
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/cypress-base/cypress/e2e/dashboard/drillby.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ describe('Drill by modal', () => {
]);
});

it('Radar Chart', () => {
it.skip('Radar Chart', () => {
testEchart('radar', 'Radar Chart', [
[182, 49],
[423, 91],
Expand Down
8 changes: 4 additions & 4 deletions superset-frontend/cypress-base/cypress/e2e/dashboard/drilltodetail.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ describe('Drill to detail modal', () => {
});
});

describe('Bar Chart', () => {
describe.skip('Bar Chart', () => {
it('opens the modal with the correct filters', () => {
interceptSamples();

Expand Down Expand Up @@ -373,7 +373,7 @@ describe('Drill to detail modal', () => {
});
});

describe('Area Chart', () => {
describe.skip('Area Chart', () => {
it('opens the modal with the correct filters', () => {
testTimeChart('echarts_area');
});
Expand Down Expand Up @@ -407,7 +407,7 @@ describe('Drill to detail modal', () => {
});
});

describe('World Map', () => {
describe.skip('World Map', () => {
it('opens the modal with the correct filters', () => {
interceptSamples();

Expand Down Expand Up @@ -567,7 +567,7 @@ describe('Drill to detail modal', () => {
});
});

describe('Radar Chart', () => {
describe.skip('Radar Chart', () => {
it('opens the modal with the correct filters', () => {
interceptSamples();

Expand Down
6 changes: 3 additions & 3 deletions superset-frontend/cypress-base/cypress/e2e/dashboard/horizontalFilterBar.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ describe('Horizontal FilterBar', () => {
validateFilterNameOnDashboard(testItems.topTenChart.filterColumn);
});

it('should spot changes in "more filters" and apply their values', () => {
it.skip('should spot changes in "more filters" and apply their values', () => {
cy.intercept(`/api/v1/chart/data?form_data=**`).as('chart');
prepareDashboardFilters([
{ name: 'test_1', column: 'country_name', datasetId: 2 },
Expand Down Expand Up @@ -204,7 +204,7 @@ describe('Horizontal FilterBar', () => {
);
});

it('should focus filter and open "more filters" programmatically', () => {
it.skip('should focus filter and open "more filters" programmatically', () => {
prepareDashboardFilters([
{ name: 'test_1', column: 'country_name', datasetId: 2 },
{ name: 'test_2', column: 'country_code', datasetId: 2 },
Expand All @@ -231,7 +231,7 @@ describe('Horizontal FilterBar', () => {
cy.get('.ant-select-focused').should('be.visible');
});

it('should show tag count and one plain tag on focus and only count on blur in select ', () => {
it.skip('should show tag count and one plain tag on focus and only count on blur in select ', () => {
prepareDashboardFilters([
{ name: 'test_1', column: 'country_name', datasetId: 2 },
]);
Expand Down
Loading