Gregt/lazy load #36

Engywook2005 · 2023-05-03T15:53:41Z

What does this PR do?

Adds means of setting LazyLoad with GPT and disables viewability check if lazyloading is active.

PR Readiness

Changes have been validated in local dev

Code Readiness

Code follows AT Media styles and conventions
Code has been auto-formatted and is free of lint errors
Unrelated code changes are not present
Relevant inline documentation or READMEs have been updated
Application and browser logs reviewed for runtime warnings and errors
Correct level of logging added to code

Automated Testing

Unit tests are written at the appropriate level given the code’s risk-level
Existing tests still pass
No unnecessary test runner output, e.g. debugging or warnings are not present in Jest or Unittest output

Other Considerations

Relevant documentation updated in Slite

Also consider this PR's impact on architecture and security; AMP, Apple News, RSS; SEO, GA, performance and accessibility.

Please see Post Merge for additional responsibilities after this PR is merged.

andrew-sotiriou · 2023-05-03T18:36:44Z

src/utils/isInViewport.js

@@ -23,4 +23,5 @@ export default function isInViewport(el, [width, height] = [0, 0], offset = 0) {
        rect.left <= viewport.right - width * offset;

    return inViewport;
+    // return true;


is this needed?

Nope... removed.

andrew-sotiriou

good to go

* Add stuff for lazy load * First shot at ignoring isInViewport response. * Will render ads even if the inviewport check fails * Removed commented out line of code * Version bump and changelog update --------- Co-authored-by: Andrew Sotiriou <[email protected]> Co-authored-by: Greg Thorson <[email protected]>

* Enable non-personalized Ads (#1) * Enable non-personalized Ads According to EU regulations, it is mandatory to enable users to opt-out to tracking cookies GPT allows us to respect this law using the `npa` flag on Ads. * Adding npa flag to re-render props * Fix npa variable in componentWillReceiveProps * Increase the bundle-size to accept the new amount of code * Changed the place where NPA is set * Update Bling.js Fixes an issue where `setAttributes` can be called when there is no ad slot * Bump to 2.0.2 * chore: Update package.json Update package.json name and urls after forking * chore: Update API list Update GPT API list to latest * chore: Add prettier config (#3) Add prettier config and fix bracket spacing mismatch * Fixing things * fix: Don't setState on unmounted ad (#5) Don't set state on an unmounted ad. Cribbed from axioscode@9425436. * fix: Fix undefined function if apiNotReady (#6) Fix undefined function if apiNotReady. Cribbed from ticketmaster@5ef19b1. * fix: Replace hasOwnProperty with more reliable check (#7) Replace hasOwnProperty with more reliable check. Cribbed from nfl@8826ee3. * fix: Do not refresh all ads when new component loads (#8) Fixes an issue where all ad slots would reload when syncCorrelator was true and a new slot was added * refactor: Check for updateCorrelator (#9) Check for deprecated updateCorrelator method before calling * build: Update radium (#10) * build: Update radium Update radium to fix "TypeError: Cannot read property 'object' of undefined" when running examples * Use ^ * Fixing things * fix: Stop multiple refresh on mq change (#11) * fix: Stop multiple refresh on mq change Stops multiple calls to instance.refresh() on media query change. This can happen when an instance is associated with multiple instances. * Only debounce this.refresh * Fix comment * Merge it * feat: Add support for custom refresh function (#14) Adds the ability to specify a custom refresh function using `configure`. This function replaces the call to `pubads().refresh`. This is useful for certain header bidding configurations, such as App Nexus that requires to `pbjs.refresh` to be called. * work this time * perf: Use googletag.cmd.push instead of timeout to process queue (#16) Use googletag.cmd.push instead of timeout to check if pubads is ready. Fixes issue with recurring handler. * work this time * Update all instances of googletagservices gpt url to securepubads gpt url (#20) * Update all instances of googletagservices gpt url to securepubads gpt url * Add UNSAFE so we can look to update REACT * update remaining paths; use https to avoid redirect Co-authored-by: Andrew Berry <[email protected]> * update linking instructions; some cleanup (#21) * remove enableServices timeout from GPT mock (#22) * Release 2.1.2 (#24) * Remove deprecated ContentService (#23) * Remove deprecated ContentService usage * Update test * doc updates Co-authored-by: Andrew Sotiriou <[email protected]> * update changelog and version in package.json (#25) * Ton of MI updates (#26) * Ton of MI updates * Minor changes * change release and update changelog (#27) * Gregt/negative viewable threshold (#28) * Can work with negative viewability threshold. * Offset in log remark is now VT for clarity. * Checking for isNaN * removed logging Co-authored-by: Engywook2005 <[email protected]> * Changed version and updated changelog (#29) * Changed version and updated changelog * Fixed typo in package.json Co-authored-by: Engywook2005 <[email protected]> * Andrew s/neg vt issue (#30) * Fixes for neg VT * Update isHidden * Cleanup * Remove log * Update call * Release 2 1 6 (#31) * update packageJSON version * Update changelog * add prepare script * Revert "add prepare script" This reverts commit 49fcf5b. * React v17 support (#32) * update deps * update radium to version supporting react 17 * add prepare script * remove prepare script * findDOMNode is deprecated * make peerDependencies more lenient * ref needs to be on different node * Reverting the version as i will do that in another step --------- Co-authored-by: Andrew Sotiriou <[email protected]> * release branch (#33) * Remove console log (#34) * Update package and remove console log (#35) * Gregt/lazy load (#36) * Add stuff for lazy load * First shot at ignoring isInViewport response. * Will render ads even if the inviewport check fails * Removed commented out line of code * Version bump and changelog update --------- Co-authored-by: Andrew Sotiriou <[email protected]> Co-authored-by: Greg Thorson <[email protected]> --------- Co-authored-by: Carlos A. Gomes <[email protected]> Co-authored-by: Carlos Gomes <[email protected]> Co-authored-by: Michael Blanchard <[email protected]> Co-authored-by: Mike Kruk <[email protected]> Co-authored-by: Andrew Berry <[email protected]> Co-authored-by: Andrew Berry <[email protected]> Co-authored-by: Greg Thorson <[email protected]> Co-authored-by: Engywook2005 <[email protected]> Co-authored-by: Stephen Sauceda <[email protected]> Co-authored-by: Greg Thorson <[email protected]>

andrew-sotiriou and others added 3 commits April 27, 2023 12:15

Add stuff for lazy load

6c14e83

First shot at ignoring isInViewport response.

34652b5

Will render ads even if the inviewport check fails

2707cb0

Engywook2005 requested a review from andrew-sotiriou May 3, 2023 17:31

andrew-sotiriou reviewed May 3, 2023

View reviewed changes

Removed commented out line of code

f816901

andrew-sotiriou approved these changes May 9, 2023

View reviewed changes

Version bump and changelog update

59026c1

Engywook2005 merged commit 4a76651 into master May 10, 2023

andrew-sotiriou deleted the gregt/lazy-load branch January 8, 2024 19:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gregt/lazy load #36

Gregt/lazy load #36

Engywook2005 commented May 3, 2023 •

edited

Loading

andrew-sotiriou May 3, 2023

Engywook2005 May 3, 2023

andrew-sotiriou left a comment

Gregt/lazy load #36

Gregt/lazy load #36

Conversation

Engywook2005 commented May 3, 2023 • edited Loading

What does this PR do?

How can this change be manually tested?

Questions or concerns about this change?

Deployment Notes

PR Readiness

Code Readiness

Automated Testing

Other Considerations

andrew-sotiriou May 3, 2023

Choose a reason for hiding this comment

Engywook2005 May 3, 2023

Choose a reason for hiding this comment

andrew-sotiriou left a comment

Choose a reason for hiding this comment

Engywook2005 commented May 3, 2023 •

edited

Loading