fix: Make console unavailable in sandbox hooks under node >= 8

Addressing apiaryio/pitboss#13 Close #754
apiaryio · Jan 18, 2018 · 23b3927 · 23b3927
1 parent 2b2eba3
commit 23b3927
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/transaction-runner.coffee b/src/transaction-runner.coffee
@@ -197,6 +197,15 @@ class TransactionRunner
 
   sandboxedWrappedCode: (hookCode) ->
     return """
+      // make console unavailable
+      try {
+        // node >= 8
+        console = undefined;
+      } catch (_exc) {
+        // node < 8
+        var console = undefined;
+      }
+
       // run the hook
       var log = _log.bind(null, _logs);
 

diff --git a/test/unit/transaction-runner-test.coffee b/test/unit/transaction-runner-test.coffee
@@ -2468,5 +2468,5 @@ describe 'TransactionRunner', ->
         """
         runner.runHook hook, {}, (err) ->
           assert.isDefined err
-          assert.include err, 'console'
+          assert.include err, 'Cannot read property \'log\' of undefined'
           done()