Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Support for Node 8 when it becomes LTS #754

Closed
honzajavorek opened this issue Mar 20, 2017 · 4 comments
Closed

Support for Node 8 when it becomes LTS #754

honzajavorek opened this issue Mar 20, 2017 · 4 comments

Comments

@honzajavorek
Copy link
Contributor

Based on #750 and snikch/goodman#22 (comment), there could be issues with Dredd on Node 7. It would be nice to add Node 7 to the testing matrix in Travis CI and to bump also various different places to mention 7 instead of 6 (e.g. AppVeyor builds).

Anyone willing to contribute this?

@honzajavorek
Copy link
Contributor Author

According to this document it's better to wait for Node 8 to become LTS and then to switch.

@honzajavorek honzajavorek changed the title Support for Node 7 Support for Node 8 when it becomes LTS Jun 5, 2017
@honzajavorek
Copy link
Contributor Author

I tried to build Dredd on Node 8, it fails - https://travis-ci.org/apiaryio/dredd/jobs/292155038 Needs more work than just adding to the build matrix.

@honzajavorek
Copy link
Contributor Author

honzajavorek commented Jan 11, 2018

Update: Everything works except some nuances in the sandboxed hooks (specificially, the test/unit/transaction-runner-test.coffee file). The Pitboss library doesn't seem to support Node 8 correctly, but I am yet to verify that. Two possible solutions:


Update: Verified it's Pitboss inconsistency between Node versions apiaryio/pitboss#13

@honzajavorek
Copy link
Contributor Author

Node 8 is already in .travis.yml for some time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant