Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Add Node 8, drop Node 4 #946

Closed
wants to merge 8 commits into from
Closed

Add Node 8, drop Node 4 #946

wants to merge 8 commits into from

Conversation

honzajavorek
Copy link
Contributor

@honzajavorek honzajavorek commented Jan 11, 2018

🚀 Why this change?

  • Node 8 is the latest even production-ready version and we should be sure Dredd supports it correctly.
  • Node 4 end of life is April 2018 and there is no reason in supporting it anymore.
  • We should not rely on loose dependency versioning - because there's no guarantee the interface, license, etc. won't change in minor or patch version. Semantic versioning is a nice idea, but not everyone follows it. Let's turn on Greenkeeper for this repo and let's pin all dependencies. Also adding package-lock.json as that's the standard way to work with npm@5 now.

📝 Related issues and Pull Requests

✅ What didn't I forget?

  • To write docs
  • To write tests
  • To put Conventional Changelog prefixes in front of all my commits and run npm run lint

@honzajavorek
Copy link
Contributor Author

@michalholasek If you like the changes, leaving up to you whether you want to merge this now or cherry-pick the commits at the end of your decaff PR and merge those together when the thing is ready.

@michalholasek
Copy link
Contributor

@honzajavorek I am ok with merging it before decaff branch is done, just one note - shouldn't we consider this a breaking change, since we are dropping Node 4 support?

@honzajavorek
Copy link
Contributor Author

@michalholasek It is a breaking change:

image

@honzajavorek honzajavorek deleted the honzajavorek/node8 branch February 2, 2018 07:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Node 8 when it becomes LTS
2 participants