This repository has been archived by the owner on Nov 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honzajavorek
force-pushed
the
honzajavorek/node8
branch
from
January 11, 2018 17:58
bc5d120
to
76058e8
Compare
honzajavorek
force-pushed
the
honzajavorek/node8
branch
from
January 18, 2018 20:07
bc7899a
to
1198012
Compare
This fixes various issues in tests caused by 62208b8
BREAKING CHANGE: From this release, Dredd is not tested on Node 4 anymore. Node 4 end of life is April 2018.
honzajavorek
force-pushed
the
honzajavorek/node8
branch
from
January 18, 2018 23:10
1198012
to
336af5c
Compare
@michalholasek If you like the changes, leaving up to you whether you want to merge this now or cherry-pick the commits at the end of your decaff PR and merge those together when the thing is ready. |
@honzajavorek I am ok with merging it before decaff branch is done, just one note - shouldn't we consider this a breaking change, since we are dropping Node 4 support? |
@michalholasek It is a breaking change: |
michalholasek
approved these changes
Jan 22, 2018
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Why this change?
package-lock.json
as that's the standard way to work withnpm@5
now.📝 Related issues and Pull Requests
✅ What didn't I forget?
npm run lint