Fix issue when JSON object map to raw String it loses quotes #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case when JSON object / array is mapped to plain `String` call proper JSON serialization instead of `value.toString()`. Also it appears that `UnmodifiableMapBuilder` doesn't preserve order that seem really odd. Bump version to `1.3.3` Closes apollographql#2012
tasomaniac
approved these changes
Mar 5, 2020
tasomaniac
reviewed
Mar 6, 2020
apollo-api/src/main/java/com/apollographql/apollo/response/ScalarTypeAdapters.java
Outdated
Show resolved
Hide resolved
…larTypeAdapters.java
|
I fixed the checkstyle issue but now tests are failing. Can you have a look? |
sav007
added a commit
that referenced
this pull request
Mar 7, 2020
* Ignore BOM symbol when parsing GraphQL schema (#2039) Closes #2017 * Fix issue when JSON object map to raw String it loses quotes (#2037) * Fix issue when JSON object map to raw String it loses quotes In case when JSON object / array is mapped to plain `String` call proper JSON serialization instead of `value.toString()`. Also it appears that `UnmodifiableMapBuilder` doesn't preserve order that seem really odd. Bump version to `1.3.3` Closes #2012 * Revert version back * Update apollo-api/src/main/java/com/apollographql/apollo/response/ScalarTypeAdapters.java * Fix tests Co-authored-by: Said Tahsin Dane <[email protected]> * Fix issue with lowercase enum type names (#2045) Closes #1901 * Change version to snapshot * release 1.3.3 * version is now 1.3.4-SNAPSHOT Co-authored-by: Ivan Savytskyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case when JSON object / array is mapped to plain
Stringcall proper JSON serialization instead ofvalue.toString().Also it appears that
UnmodifiableMapBuilderdoesn't preserve order that seem really odd.Closes #2012